Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 2E110431FAF for ; Sat, 27 Oct 2012 02:34:20 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 2.7 X-Spam-Level: ** X-Spam-Status: No, score=2.7 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_ENVFROM_END_DIGIT=1, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=2.499, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id N6mjLPIX7Mdc for ; Sat, 27 Oct 2012 02:34:19 -0700 (PDT) Received: from mail-we0-f181.google.com (mail-we0-f181.google.com [74.125.82.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 8CA7E431FAE for ; Sat, 27 Oct 2012 02:34:19 -0700 (PDT) Received: by mail-we0-f181.google.com with SMTP id u54so1954310wey.26 for ; Sat, 27 Oct 2012 02:34:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer; bh=BYD4FsoUt1vD5VqzI5J52W+DgHdlQpM7491EIB6sRnM=; b=iBZkO1JMy3nUFyk0xk4YFaAnrQr7ACU/nt/QcOYGAu4aPW4Bs2/9LbORPnMJDly3Q7 qJl93PmOkaM7BZQ16/yOlj6mbacWUVu7eXMinSxJm26uMU2dVQPobdkvTxuzFiPPW9Lq qFHQFH7iINCMSuc1SXe9r750rGszudW3AH1JKJH4Bd2udBY0NLdmh6wkkjFwWyEoX+ie 3bWs0NxqFUn/cwHQxHW1QT2sIEWxdOm025Z2RoWlHVFZaX9XUxM/UdjElnL7+HiGKHOG GOnewer4nLEuPGX6KwcXllwLcRsk7PIsIal0IMsIxyTfm17xTVNr+k/TLvmdDVBYmMo/ Jmxg== Received: by 10.216.145.156 with SMTP id p28mr13893215wej.140.1351330456938; Sat, 27 Oct 2012 02:34:16 -0700 (PDT) Received: from localhost (93-97-24-31.zone5.bethere.co.uk. [93.97.24.31]) by mx.google.com with ESMTPS id b7sm1563250wiz.3.2012.10.27.02.34.14 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 27 Oct 2012 02:34:15 -0700 (PDT) From: Mark Walters To: notmuch@notmuchmail.org Subject: [PATCH v4 0/3] split async json parser into utility function Date: Sat, 27 Oct 2012 10:34:09 +0100 Message-Id: <1351330452-8348-1-git-send-email-markwalters1009@gmail.com> X-Mailer: git-send-email 1.7.9.1 X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Oct 2012 09:34:20 -0000 This is version 4 of this patch set (v3 is at id:"1351037602-11157-1-git-send-email-markwalters1009@gmail.com"). It splits the async json parser into its own function and moves it to lib. This version is very similar to v3 except that it finished by moving the utility function to lib rather than leaving it notmuch.el. It also improves some of the docstrings to clarify how the function and variables work. I have not gone quite as far as suggested by Ethan as these variables are purely for internal use and Austin's code is well documented. Best wishes Mark Mark Walters (3): emacs: Split out the incremental json parser into its own function emacs: Rename incremental JSON internal variables emacs: Move the incremental JSON parser to notmuch-lib.el emacs/notmuch-lib.el | 66 ++++++++++++++++++++++++++++++++++++++++++++++++++ emacs/notmuch.el | 48 +++--------------------------------- 2 files changed, 70 insertions(+), 44 deletions(-) -- 1.7.9.1