Date: Sun, 28 Feb 2016 14:46:07 +0000
From: Franz Fellner <alpine.art.de@gmail.com>
Subject: Re: need to call notmuch_threads_get (..) to actually move iterator
To: Gaute Hope <eg@gaute.vetsj.com>, notmuch@notmuchmail.org
References: <1456315381-astroid-1-8aih8mdal8-11676@strange>
 <1456669181-astroid-0-hsim583msj-27330@TP_L520>
In-Reply-To: <1456669181-astroid-0-hsim583msj-27330@TP_L520>
User-Agent: astroid/v0.5-61-gab5b649c (https://github.com/gauteh/astroid)
Message-Id: <1456670385-astroid-0-hgj454pqy2-29417@TP_L520>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Precedence: list

Really might be the issue: Threads with many messages duplicate more
often than messages with few messages. Threads with only one message
never seem to come up more than twice.
Currently I don't have the time to track down what actually get's stored
in match_set, would be nice if a dev could shed some light on it. Thx!

Excerpts from Franz Fellner's message of Februar 28, 2016 3:26 :
> It might be I found the issue:
> One big thing notmuch_threads_get does is remove the thread_id from the
> match_set. Playing with astroid (branch ti-skip-and-load) i see that it
> is not entirely true that the iterator doesn't move. It just seems to
> duplicate some messages. There definitely are coming new messages.
> So my explanation is that match_set contains duplicate thread_ids. If
> that is true a solution to Gautes problem might be to deduplicate the
> match_set.
>=20
> Excerpts from Gaute Hope's message of Februar 24, 2016 1:08 :
>> Hi,
>>=20
>> it seems to be necessary to actually call notmuch_threads_get (threads)
>> to move the thread iterator from a query object, just calling
>> notmuch_threads_move_to_next (..) is not enough:
>>=20
>> ```
>>=20
>> notmuch_query_t *query;
>> notmuch_threads_t *threads;
>> notmuch_thread_t *thread;
>>=20
>> query =3D notmuch_query_create (database, query_string);
>> threads =3D notmuch_query_search_threads (query);
>>=20
>> int i =3D 0;
>>=20
>> for (;
>>      notmuch_threads_valid (threads);
>>      notmuch_threads_move_to_next (threads))
>> {
>>     /*
>>      * with this line commented out the iterator seems to remain in
>>      * place, and if I below do another loop it will start from the
>>      * beginning.
>>=20
>>     thread =3D notmuch_threads_get (threads);
>>     ....
>>     notmuch_thread_destroy (thread);
>>     */
>>=20
>>     i++;
>>     if (i > 100) break;
>> }
>>=20
>> for (;
>>      notmuch_threads_valid (threads);
>>      notmuch_threads_move_to_next (threads))
>> {
>>     /* the thread acquired here will be the first thread in the query.
>>      * it should be the 101th. */
>>=20
>>     thread =3D notmuch_threads_get (threads);
>>     ....
>>     notmuch_thread_destroy (thread);
>>=20
>> }
>>=20
>>=20
>> notmuch_query_destroy (query);
>> ```
>>=20
>> It is quite slow to skip the threads in this way, might it be faster if
>> move_to_next works correctly?
>>=20
>> Regards, Gaute
>>=20
>> _______________________________________________
>> notmuch mailing list
>> notmuch@notmuchmail.org
>> https://notmuchmail.org/mailman/listinfo/notmuch
>>=20
>=20
=