Return-Path: <tomi.ollila@iki.fi>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 98E27431FAF
	for <notmuch@notmuchmail.org>; Thu, 15 Nov 2012 07:21:45 -0800 (PST)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level: 
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
	autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id pKwCz1OC+p-7 for <notmuch@notmuchmail.org>;
	Thu, 15 Nov 2012 07:21:44 -0800 (PST)
Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
	by olra.theworths.org (Postfix) with ESMTP id 63926431FAE
	for <notmuch@notmuchmail.org>; Thu, 15 Nov 2012 07:21:44 -0800 (PST)
Received: from guru.guru-group.fi (localhost [IPv6:::1])
	by guru.guru-group.fi (Postfix) with ESMTP id EA4361000E2;
	Thu, 15 Nov 2012 17:21:43 +0200 (EET)
From: Tomi Ollila <tomi.ollila@iki.fi>
To: david@tethera.net, notmuch@notmuchmail.org
Subject: Re: [PATCH 2/3] notmuch-restore: tidy formatting
In-Reply-To: <1352943202-1431-3-git-send-email-david@tethera.net>
References: <1352943202-1431-1-git-send-email-david@tethera.net>
	<1352943202-1431-3-git-send-email-david@tethera.net>
User-Agent: Notmuch/0.14+84~g8a199bf (http://notmuchmail.org) Emacs/24.2.1
	(x86_64-unknown-linux-gnu)
X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
	!)g;OY^,BjTbr)Np:%c_o'jj,Z
Date: Thu, 15 Nov 2012 17:21:43 +0200
Message-ID: <m2mwyix56g.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
Cc: David Bremner <bremner@debian.org>
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Nov 2012 15:21:45 -0000

On Thu, Nov 15 2012, david@tethera.net wrote:

> From: David Bremner <bremner@debian.org>
>
> This is again the work of uncrustify.
>
> I remember there is some controversy about "! foo" versus "!foo", but
> in context I think "! foo" looks OK. Also, for functions "! foo
> (blah)" seems better than "!foo (blah)".

Currently:
$ egrep '! ' *.c | wc
     19     108    1074
$ egrep '![^ =]' *.c | wc 
     41     250    2223

Anyway IIRC Carl preferred the ! foo format and the code might
have drifted away from that...

Whatever this choice will eventually be for "pure" notmuch code
should not affect what the code that can be considered as
external libraries should be formatted; e.g. parse-time-string
code should keep the formatting Jani prefers.

The uncrustify.cfg option 'sp_not' affects whether there is
space after ! or not -- and it can even be configured to 'ignore'
this case.

Tomi

// patch dropped.