Return-Path: <doctormo@gmail.com>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id C79E3429E26
	for <notmuch@notmuchmail.org>; Thu,  8 Sep 2011 19:54:27 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: -0.799
X-Spam-Level: 
X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
	tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
	FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 1OaLbwxOFsbD for <notmuch@notmuchmail.org>;
	Thu,  8 Sep 2011 19:54:26 -0700 (PDT)
Received: from mail-qw0-f43.google.com (mail-qw0-f43.google.com
	[209.85.216.43]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
	(No client certificate requested)
	by olra.theworths.org (Postfix) with ESMTPS id 34637431FD0
	for <notmuch@notmuchmail.org>; Thu,  8 Sep 2011 19:54:26 -0700 (PDT)
Received: by qwm42 with SMTP id 42so1228717qwm.2
	for <notmuch@notmuchmail.org>; Thu, 08 Sep 2011 19:54:24 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=subject:from:to:cc:in-reply-to:references:content-type:date
	:message-id:mime-version:x-mailer:content-transfer-encoding;
	bh=G5NZ/81baRoGsTBjUVAh+bu9mz9QT+LFLt+dMoge8fY=;
	b=o3/9S/iOWlsXvwOB5nE9ghtn92U6giPS9MYtftF9dH5bAJElyYD1oloFqvhbBKsQhU
	VU3k+Mfr2cuTNd/ci6DWywSju+F+i4IUh3nsJwOdnde6rlRcB9v91+t2BgOGvaBAmkyB
	S1H9rYFX6uggIG/eNBb/e6D+UAnD1GRsLtA5I=
Received: by 10.224.210.134 with SMTP id gk6mr1112299qab.12.1315536864305;
	Thu, 08 Sep 2011 19:54:24 -0700 (PDT)
Received: from [192.168.1.190] (pool-68-163-190-45.bos.east.verizon.net.
	[68.163.190.45])
	by mx.google.com with ESMTPS id dx7sm4617250qab.11.2011.09.08.19.54.22
	(version=SSLv3 cipher=OTHER); Thu, 08 Sep 2011 19:54:23 -0700 (PDT)
Subject: Re: Patch: Flush and Reopen
From: Martin Owens <doctormo@gmail.com>
To: Austin Clements <amdragon@mit.edu>
In-Reply-To:
 <CAH-f9WtuYYuksfTHL1ZMmoRF6kyL7iFu9BXDzGn-wWGniSvf9w@mail.gmail.com>
References: <1315445674.32058.183.camel@delen>
	<CAH-f9WtuYYuksfTHL1ZMmoRF6kyL7iFu9BXDzGn-wWGniSvf9w@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Date: Thu, 08 Sep 2011 22:54:21 -0400
Message-ID: <1315536861.2435.34.camel@delen>
Mime-Version: 1.0
X-Mailer: Evolution 2.30.3 
Content-Transfer-Encoding: 7bit
Cc: Paul Tagliamonte <paultag@ubuntu.com>,
	Notmuch developer list <notmuch@notmuchmail.org>
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Sep 2011 02:54:27 -0000

Hey Austin,

Thanks for the review :-) I'll attempt to fix some of the style
guidelines, but see below.

On Thu, 2011-09-08 at 22:42 -0400, Austin Clements wrote:
> Did you mean to change this?

This fails to build on Ubuntu maverick with the extra .3 and I see no
reason to have that sub-minor version. Pushing it in would probably be
useful unless there is a real reason.

> This cast will fail.  Shouldn't this just be a wrapper around
> notmuch->xapian_db->reopen? 

I'm a python programmer, c wrappers are beyond me unfortunately. Your
help implementing that would be really good.

Best regards, Martin Owens