From: Carl Worth <cworth@cworth.org>
To: "martin f. krafft" <madduck@madduck.net>, notmuch@notmuchmail.org
Subject: Re: [notmuch] [PATCH] Do not segfault on empty mime parts
In-Reply-To: <1267543888-18134-1-git-send-email-madduck@madduck.net>
References: <1267543888-18134-1-git-send-email-madduck@madduck.net>
Date: Tue, 13 Apr 2010 08:55:01 -0700
Message-ID: <87ljcre4a2.fsf@yoom.home.cworth.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Cc: "martin f. krafft" <madduck@madduck.net>
Precedence: list

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Tue,  2 Mar 2010 16:31:28 +0100, "martin f. krafft" <madduck@madduck.net=
> wrote:
> notmuch previously unconditionally checked mime parts for various
> properties, but not for NULL, which is the case if libgmime encounters
> an empty mime part.

Thanks for the fix.

> Upon encounter of an empty mime part, the following is printed to
> stderr (the second line due to my patch):
>=20
>   (process:17197): gmime-CRITICAL **: g_mime_message_get_mime_part: asser=
tion `GMIME_IS_MESSAGE (message)' failed
>   Warning: Not indexing empty mime part.

That message is all quite ugly. I'm perpetually annoyed by libraries
that claim to detect major problems, (even "CRITICAL" problems!), and
just print messages and march along.

Either there *is* a critical problem here, in which case the library
should halt after printing the message, (see for example, what notmuch
does with its INTERNAL_ERROR macro), or there's no problem at all and
the code should operate correctly without these obnoxious messages.

Anyway, I've put a note into TODO that we should do the following (in
order):

  1. Add a test case to trigger this message

  2. File a bug against GMime to eliminate its portion of the message

  3. Remove the notmuch portion of the message

=2DCarl

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iD8DBQFLxJPV6JDdNq8qSWgRApdxAJ9kLDhwuKnm6PUo4tYQbS20SUiwMQCdHSUA
8n/6OWa8t9JPf6mdmiF0fSs=
=0ETF
-----END PGP SIGNATURE-----
--=-=-=--