From: Michal Sojka <sojkam1@fel.cvut.cz>
To: Andreas Amann <andreas.amann@tyndall.ie>, notmuch@notmuchmail.org
Subject: Re: [PATCH] Allow user to specify ignored directories
In-Reply-To: <ylp7hi23mw8.fsf@tyndall.ie>
References: <ylp7hi23mw8.fsf@tyndall.ie>
User-Agent: Notmuch/0.3.1-83-g6fec75f (http://notmuchmail.org) Emacs/23.2.1
	(x86_64-pc-linux-gnu)
Date: Wed, 13 Oct 2010 11:09:01 +0200
Message-ID: <87zkui1mtu.fsf@steelpick.2x.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list

On Thu, 30 Sep 2010, Andreas Amann wrote:
> Hi list,
> 
> this is my first post. I found notmuch a couple of days ago and it works
> great. However I wanted to be able to ignore certain directories (mostly
> .git in my case) when "notmuch new" is running. 
> 
> With this patch the user can provide a list of directories which are
> ignored during the recursive search for new messages. An "ignore"
> label in the "new" section of the configuration file is added for this
> purpose to enable for example something like

Hi,

thanks, the patch seems good to me. See the comment bellow.


> @@ -202,7 +219,8 @@ _entries_resemble_maildir (struct dirent **entries, int count)
>  static notmuch_status_t
>  add_files_recursive (notmuch_database_t *notmuch,
>                      const char *path,
> -                    add_files_state_t *state)
> +                    add_files_state_t *state,
> +                     notmuch_config_t *config)

I would not add additional parameter here. It's IMHO better to add field
"ignored_files" to add_files_state_t similarly as it is done for
new_tags.

-Michal