Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 0678A431FAE for ; Sun, 11 Mar 2012 11:42:16 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dhTAPieaFnwN for ; Sun, 11 Mar 2012 11:42:11 -0700 (PDT) Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66]) by olra.theworths.org (Postfix) with ESMTP id 63403431FAF for ; Sun, 11 Mar 2012 11:42:11 -0700 (PDT) Received: by guru.guru-group.fi (Postfix, from userid 501) id ED57468055; Sun, 11 Mar 2012 20:42:09 +0200 (EET) From: Tomi Ollila To: Pieter Praet , Notmuch Mail Subject: Re: [PATCH v4] test: emacs: new test "notmuch-search: change tags of all matching messages" In-Reply-To: <1331149792-17192-1-git-send-email-pieter@praet.org> References: <1329936867-923-1-git-send-email-pieter@praet.org> <1331149792-17192-1-git-send-email-pieter@praet.org> User-Agent: Notmuch/0.11.1+288~g4b3af0e (http://notmuchmail.org) Emacs/23.3.1 (x86_64-unknown-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Mar 2012 18:42:16 -0000 On Wed, 7 Mar 2012 20:49:52 +0100, Pieter Praet wrote: > * test/emacs-search: > > - New subtest "notmuch-search: change tags of all matching messages": > `notmuch-search-tag-all' (bound to "*") adds and removes tags > to/from all messages which match the query used to populate the > current search buffer. > --- > > Moved to a separate file to prevent a merge conflict when applied in > conjunction with the patches listed @ id:"877gz4dnl2.fsf@praet.org". Hi Pieter! I did the following script: --8<----8<----8<----8<----8<----8<----8<----8<----8<----8<----8<-- #!/bin/sh while read line do case $line in id:*) notmuch show --format=mbox "$line" esac done < "$0" | git am exit 0 id:"1329684990-12504-2-git-send-email-pieter@praet.org" id:"1329684990-12504-3-git-send-email-pieter@praet.org" id:"1329684990-12504-4-git-send-email-pieter@praet.org" id:"1330122640-18895-2-git-send-email-pieter@praet.org" id:"1330122640-18895-3-git-send-email-pieter@praet.org" id:"1331149792-17192-1-git-send-email-pieter@praet.org" --8<----8<----8<----8<----8<----8<----8<----8<----8<----8<----8<-- When executed on top of current master (c46764030d, 0.11.1-1-293-gc467640) last patch (1331149792-17192-1..., this I'm replying to) fails as: error: patch failed: test/notmuch-test:54 error: test/notmuch-test: patch does not apply In order to get clear picture of the changes you wish to get reviewed please provide cleanly applicable patchset. The best possible way to inform what is to be reviewed is 1) List of message id:s of the patches, in order those are to be applied. 2) Sha1 of the commit where this patchset applies cleanly (In this case I will do review even though it would not apply on top of current master (at that time) anymore -- but *I* would not expect it to to be pushed until rebased patchset is sent again). BR, Tomi