To: Sebastian Spaeth <Sebastian@SSpaeth.de>, notmuch <notmuch@notmuchmail.org>
Subject: Re: Python bindings and Xapian exceptions
In-Reply-To: <878w6gis5g.fsf@SSpaeth.de>
References: <87k4q7s43v.fsf@ut.hh.sledj.net> <878w6gis5g.fsf@SSpaeth.de>
User-Agent: Notmuch/0.3.1-53-gb7aeaa1 (http://notmuchmail.org) Emacs/23.1.1
	(x86_64-pc-linux-gnu)
From: David Edmondson <dme@dme.org>
Date: Tue, 15 Jun 2010 10:17:25 +0100
Message-ID: <874oh4ejtm.fsf@ut.hh.sledj.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Precedence: list

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Tue, 15 Jun 2010 11:03:55 +0200, "Sebastian Spaeth" <Sebastian@SSpaeth.d=
e> wrote:
> >   A Xapian exception occurred finding message: The revision being read
> >   has been discarded - you should call Xapian::Database::reopen() and
> >   retry the operation.
> > It makes the Python bindings almost useless to me.
>=20
> Not sure, if the python bindings should simply drop and reopen a
> database connection in that case? But I am not sure if libnotmuch.so
> still simply exits on such an error case.
>=20
> The proper fix, and a reason why I am not immediately hacking around in
> the python bindings is that notmuch the library would actually return a
> proper error value rather than print to stderr and quit.
>=20
> Happy to receive suggestions on how to handle this best from the python
> side of things.

Unfortunately I'm an ignorant about the best solution.

Having the Python layer hide the fact that the database was re-opened
seems as though it might be dangerous (in case I mix state from before
and after the re-opening), but I can't give a concrete example of
something that would fail.

Given that exception based programming is common in Python, simple
raising the exception and allowing the application to handle it appears
to make sense.

dme.
=2D-=20
David Edmondson, http://dme.org

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEUEARECAAYFAkwXRSUACgkQaezQq/BJZRZQXQCfbFwSpimczLRvdFSgKT74cDKC
DbAAmJ+ju+lNNTaWQvUULNymGKGgjMA=
=vKYv
-----END PGP SIGNATURE-----
--=-=-=--