Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id E56D2431FAF for ; Sat, 20 Oct 2012 09:08:59 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.799 X-Spam-Level: X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QlvTXBktbmWz for ; Sat, 20 Oct 2012 09:08:59 -0700 (PDT) Received: from mail-vb0-f53.google.com (mail-vb0-f53.google.com [209.85.212.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 28C5D431FAE for ; Sat, 20 Oct 2012 09:08:59 -0700 (PDT) Received: by mail-vb0-f53.google.com with SMTP id fc21so1642538vbb.26 for ; Sat, 20 Oct 2012 09:08:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-type; bh=xgjGitM/s954rXg7O49sEKuVy9fr9xWFDJisi301wcs=; b=AkO9+2kAu4UdJZzZ0tEkiBd8B5LXnEouDMDxVWFSyUj2An0oS8oj1zWEDKzQ4Azs8K tRCCwR62iNF8Z4YiN7kVQGOY60adqi3i19hzakeBlg2cJ35yYOVp7ok2ekfjcnrpTtwd yZKXq+jC3DBD+EjY9SnanDHh3PQmuglA+f0gCi0U6CewNqDaGPaMsK4n8WvtUVJJt/2S nbOtAofseR/juF/mug6FTW3DNvvav5nXMPmbRwft5a2eOqtkbsfCb0eo6ZUC6uwRqsNP UWDs0bnXdQVkk4HgkTgKMEiox1suMgmuoZVhRcfUGk/XHXCkzqd/7IIekf0IYagL7UWI jtjA== Received: by 10.52.180.5 with SMTP id dk5mr5087061vdc.45.1350749338557; Sat, 20 Oct 2012 09:08:58 -0700 (PDT) Received: from smtp.gmail.com (p70-80.acedsl.com. [66.114.70.80]) by mx.google.com with ESMTPS id co1sm4659865vdc.10.2012.10.20.09.08.57 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 20 Oct 2012 09:08:57 -0700 (PDT) From: Ethan Glasser-Camp To: Tomi Ollila , notmuch@notmuchmail.org Subject: Re: [PATCH V3 1/2] test/smtp-dummy: add --background option and functionality In-Reply-To: <1347978182-8771-1-git-send-email-tomi.ollila@iki.fi> References: <1347978182-8771-1-git-send-email-tomi.ollila@iki.fi> User-Agent: Notmuch/0.14+45~g6ea9330 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Sat, 20 Oct 2012 12:08:56 -0400 Message-ID: <87sj995dnr.fsf@betacantrips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Tomi Ollila X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Oct 2012 16:09:00 -0000 Tomi Ollila writes: > From: Tomi Ollila > > When shell executes background process using '&' the scheduling of > that new process is arbitrary. It could be that smtp-dummy doesn't > get execution time to listen() it's server socket until some other > process attempts to connect() to it. The --background option in > smtp-dummy makes it to go background *after* it started to listen > its server socket. This looks fine to me, Michal Sojka's reviewed this version, and this patch has been bouncing around for almost a year! I'm taking off needs-review. Ethan