From: Daniel Schoepe <daniel@schoepe.org>
To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH v7 2/2] emacs: Tests for user-defined sections
In-Reply-To: <87ipjv8mvn.fsf@gmail.com>
References: <87d3ac8ta9.fsf@schoepe.localhost>
	<1327193689-6011-1-git-send-email-daniel@schoepe.org>
	<1327193689-6011-2-git-send-email-daniel@schoepe.org>
	<87y5sym31d.fsf@gmail.com> <87ehujqzu6.fsf@schoepe.localhost>
	<87ipjv8mvn.fsf@gmail.com>
User-Agent: Notmuch/0.10.2+186~g93a0b67 (http://notmuchmail.org)
	Emacs/24.0.92.1 (x86_64-pc-linux-gnu)
Date: Sat, 28 Jan 2012 23:54:38 +0100
Message-ID: <87aa57qvyp.fsf@schoepe.localhost>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Precedence: list

--=-=-=
Content-Type: text/plain

Hi Dmitry.

On Sun, 29 Jan 2012 02:48, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> I only meant trailing whitespaces in test/emacs file in the lines added
> by the patch.  Trailing whitespaces in expected results are obviously
> fine.

Ah, okay. I fixed those with delete-trailing-whitespace, but then
noticed that this also corrected some trailing whitespace in unrelated
tests, reverted that and then forgot about the trailing whitespace in my
tests by the time I responded.

> I think splitting emacs tests based on -hello, -show and -search views
> is a good idea.  Splitting existing tests is out of scope of this
> patch.  But I think it may be a good opportunity to add a new file with
> -hello tests.

You're right; I'll do that if you find other flaws in your next
review. Otherwise, I'll just put it in another patch.

Cheers,
Daniel

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAEBAgAGBQJPJHyuAAoJEIaTAtce+Z+Jx78QAJPisZPcGRERql2bD1HI7q4e
Tfi+zzHrLkjZQ/g1JTkCPfbVkVR78yakdK1tM8ZZPBs7jhjyT7GL9SGfn5Qdus2Z
YdFwA/dhbvkPEHaeHYFUnemd790nKCxgfWdo4yi0hng4UDwaYBzDiZBY0Vrkcboy
gIUW04GmOQRE242f2l2nQBgKLklFRtVZQtrOLDQWdq/BWwb+lCriLLBHwPzDIzP/
sAm/2hfmfzWf2xIYd7OBYxQ5gz9h/Ow85rO+fOb6fzy98FkIIaaXn2ic0xwGiffN
ozo3TI9lYRbEkP8cI/DV3ZwYLqsMGp7We43iXu3YndPiqpF1ywAtLluhCx4jXbg8
LndmG4xJjsx3lPvFqMZORdnZFNYRXTh8CvA/5V9kdl3XUVgMpXBtwyonmtYao+4h
oalkmonuhy9u2wrt82zS0Jc24Uez7wCNiz3OWgJzxImdsr5a+jXnDZU39Hu9pp5C
G5NDaA0DxC5idi/+KXtVJdlQeufQs+QItrRfgpIlYsbHs1ga/Bz+ZXXM7ZVRdzLP
yiW49RXoFOvnYxTaEgy3E5H4/nb1euYsYcDPBfJIMsgc93N5lbShIX4QaC+dHvFr
It10ctYQ9PSN3qXJnTnD0qRh7q6c3ywwe/PLSlO+26ssr/iBIG0ap1XHkVljJoNZ
MEDDKMOm90HalV0axY1A
=t4Gq
-----END PGP SIGNATURE-----
--=-=-=--