Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 5D509429E25 for ; Fri, 16 Dec 2011 04:22:51 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.799 X-Spam-Level: X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4KYovU3AC32l for ; Fri, 16 Dec 2011 04:22:50 -0800 (PST) Received: from mail-ww0-f45.google.com (mail-ww0-f45.google.com [74.125.82.45]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 96649431FD0 for ; Fri, 16 Dec 2011 04:22:50 -0800 (PST) Received: by wgbds13 with SMTP id ds13so4857178wgb.2 for ; Fri, 16 Dec 2011 04:22:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:subject:in-reply-to:references:user-agent:date:message-id :mime-version:content-type; bh=uvlHfOrhy4TY5zykTiN11RHFuYuR1IGNv3yvxsBf/g0=; b=dUYiG679GpIkLR8Gy0F6gds+zQuLGgxkf3ln1hLXK6uo6//pXzqf1/Pw0PdyGoNG6x pkm0GMgFD1vy9A70X8TTwennmEVGTK7J521gs9GGEGHrlh5kWY/sxhHjTrac9n/Pjg// DG6Y6HkawerDuN3g+reF6oQegW6shRpXxlMDQ= Received: by 10.227.207.205 with SMTP id fz13mr5497123wbb.0.1324038169261; Fri, 16 Dec 2011 04:22:49 -0800 (PST) Received: from localhost ([91.144.186.21]) by mx.google.com with ESMTPS id er5sm14321676wbb.11.2011.12.16.04.22.46 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 16 Dec 2011 04:22:46 -0800 (PST) From: Dmitry Kurochkin To: Jani Nikula , notmuch@notmuchmail.org Subject: Re: [PATCH 1/2] emacs: Fix notmuch-hello-tag-list-make-query defcustom In-Reply-To: <864e58d004c991bcb823e0f61f33eb8cbbbb5b76.1316804530.git.jani@nikula.org> References: <864e58d004c991bcb823e0f61f33eb8cbbbb5b76.1316804530.git.jani@nikula.org> User-Agent: Notmuch/0.10.2+96~g74e5ae5 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Fri, 16 Dec 2011 16:22:07 +0400 Message-ID: <87obv8so40.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Dec 2011 12:22:51 -0000 Hi Jani. On Fri, 23 Sep 2011 22:03:41 +0300, Jani Nikula wrote: > It was not possible to define custom filters or filter functions because > the types were const. Remove const to allow editing. > How about making "Unread messages" query configurable as well? Regards, Dmitry > Signed-off-by: Jani Nikula > --- > emacs/notmuch-hello.el | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el > index 65fde75..ad1a13f 100644 > --- a/emacs/notmuch-hello.el > +++ b/emacs/notmuch-hello.el > @@ -66,8 +66,8 @@ Finally this can be a function that will be called for each tag and > should return a filter for that tag, or nil to hide the tag." > :type '(choice (const :tag "All messages" nil) > (const :tag "Unread messages" "tag:unread") > - (const :tag "Custom filter" string) > - (const :tag "Custom filter function" function)) > + (string :tag "Custom filter") > + (function :tag "Custom filter function")) > :group 'notmuch) > > (defcustom notmuch-hello-hide-tags nil > -- > 1.7.4.1 > > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch