MIME-Version: 1.0
In-Reply-To: <87vdh2exi8.fsf@yoom.home.cworth.org>
References: <87d43ay4qg.wl%djcb@djcbsoftware.nl>
	<87vdh2exi8.fsf@yoom.home.cworth.org>
Date: Sun, 22 Nov 2009 22:43:42 -0600
Message-ID: <935ead450911222043s59f3e185n8cb0d1c46bbe9f7a@mail.gmail.com>
From: Jeffrey Ollie <jeff@ocjtech.us>
To: Carl Worth <cworth@cworth.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Cc: "notmuch@notmuchmail org" <notmuch@notmuchmail.org>, djcb@djcbsoftware.nl
Subject: Re: [notmuch] [PATCH] fix compiler warnings
Precedence: list

On Sun, Nov 22, 2009 at 9:22 PM, Carl Worth <cworth@cworth.org> wrote:
> On Sun, 22 Nov 2009 17:11:03 +0200, Dirk-Jan C. Binnema <djcb.bulk@gmail.=
com> wrote:
>>
>> - =C2=A0 =C2=A0write(2, msg, sizeof(msg)-1);
>> + =C2=A0 =C2=A0if (write(2, msg, sizeof(msg)-1) < 0) {
>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 /* ignore...*/
>> + =C2=A0 =C2=A0}
>
> I don't like the gratuitous conditional here. It clutters the code and
> make is less clear. If we're just trying to squelch a warning about an
> unused return value from a function, then I think I'd rather see:
>
> =C2=A0 =C2=A0 =C2=A0 =C2=A0ssize_t ignored;
>
> =C2=A0 =C2=A0 =C2=A0 =C2=A0ignored =3D write (2, msg, sizeof (msg) - 1);

Isn't the usual method for ignoring return values casting to void?

(void) write (2, msg, sizeof (msg) - 1);

--=20
Jeff Ollie