From: Mark Walters <markwalters1009@gmail.com>
To: Damien Cassou <damien.cassou@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH v3] emacs: display tags in notmuch-show with links
In-Reply-To: <1355149964-27905-1-git-send-email-damien.cassou@gmail.com>
References: <1355149964-27905-1-git-send-email-damien.cassou@gmail.com>
User-Agent: Notmuch/0.14+155~g7edfdc3 (http://notmuchmail.org) Emacs/23.4.1
	(x86_64-pc-linux-gnu)
Date: Mon, 10 Dec 2012 16:05:23 +0000
Message-ID: <87boe1yjss.fsf@qmul.ac.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list


On Mon, 10 Dec 2012, Damien Cassou <damien.cassou@gmail.com> wrote:
> This patch obsoletes:
> id:1353266322-20318-1-git-send-email-damien.cassou@gmail.com
>
> [PATCH 1/4] emacs: Add a thread's tags to notmuch-show header-line
> [PATCH 2/4] emacs: Make tags in notmuch-show header-line clickable
> [PATCH 3/4] emacs: Make all tags in `notmuch-show' clickable
> [PATCH 4/4] emacs: Add unit-tests for clickable tags
>
> This patch makes clickable all tags that appear in notmuch-show
> buffers. Each tag is a link to open a new notmuch-search buffer for
> this tag. Additionally, the buffer's header-line now shows the
> thread's tags (clickable only if the `header-button' library is loaded
> or loadable).
>
> This patch is the first one of an upcoming series whose goal is to
> integrate notmuch-labeler into notmuch. See the following for more
> details:
> https://github.com/DamienCassou/notmuch-labeler

Hi 

I like this series but there are two (related) problems that I missed on
earlier review. 

The first is that the headerline tags are not updated when the user tags
a message, and the second is that the tags for the message itself (ie in
the emacs buffer not the headerline) are updated but cease to be
buttons.

I think the function notmuch-show-update-tags is the one that does the
updating of the display. (Incidentally that seems to break if the user
likes tags containing brackets).

This is probably the place to link to as there are lots of ways messages
get tagged.

Best wishes (and sorry for not catching this before)

Mark




>
> With respect to v2, I took care of the comments you made:
> - moved notmuch-tagger-separate-elems to notmuch-lib
> - renamed a few methods
> - changed some comments to better reflect the method behavior
> - changed links in the body so that TAB won't stop at them
> - changed miscellaneous small things
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch