Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 32286431FD0 for ; Sun, 23 Jan 2011 03:12:36 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UzcD9rg9HM7p for ; Sun, 23 Jan 2011 03:12:35 -0800 (PST) Received: from mail.loccal.net (gw.loccal.net [94.142.235.206]) by olra.theworths.org (Postfix) with ESMTP id 4D7DD431FB6 for ; Sun, 23 Jan 2011 03:12:35 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by mail.loccal.net (Postfix) with ESMTP id 05AAF1046D; Sun, 23 Jan 2011 12:25:50 +0100 (CET) X-Virus-Scanned: amavisd-new at loccal.net Received: from mail.loccal.net ([127.0.0.1]) by localhost (mail.loccal.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 435znnV5-dLI; Sun, 23 Jan 2011 12:25:46 +0100 (CET) Received: from steelpick.2x.cz (unknown [10.21.129.4]) by mail.loccal.net (Postfix) with ESMTPS id 847151043A; Sun, 23 Jan 2011 12:25:46 +0100 (CET) Received: from wsh by steelpick.2x.cz with local (Exim 4.72) (envelope-from ) id 1Pgxry-0005I4-7A; Sun, 23 Jan 2011 12:12:30 +0100 From: Michal Sojka To: notmuch@notmuchmail.org Subject: [PATCH] test: Make it easier to resolve conflicts when adding new tests Date: Sun, 23 Jan 2011 12:12:24 +0100 Message-Id: <1295781144-20308-1-git-send-email-sojkam1@fel.cvut.cz> X-Mailer: git-send-email 1.7.2.3 X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Jan 2011 11:12:36 -0000 Currently, there are two places in the test framework that contain very long list on a single line. Whenever a test is added (or changed) in several branches and these branches are merged, it results in conflict which is hard to resolve because one has to go through the whole long line to find where the conflict is. This patch splits these long lists to several lines so that the conflicts are easier to resolve. --- test/basic | 9 +++++++-- test/notmuch-test | 21 ++++++++++++++++++++- 2 files changed, 27 insertions(+), 3 deletions(-) diff --git a/test/basic b/test/basic index e1269e2..3b43ad9 100755 --- a/test/basic +++ b/test/basic @@ -51,8 +51,13 @@ test_expect_code 2 'failure to clean up causes the test to fail' ' # Ensure that all tests are being run test_begin_subtest 'Ensure that all available tests will be run by notmuch-test' -tests_in_suite=$(grep TESTS= ../notmuch-test | sed -e "s/TESTS=\"\(.*\)\"/\1/" | tr " " "\n" | sort) -available=$(ls -1 ../ | grep -v -E "^(aggregate-results.sh|Makefile|Makefile.local|notmuch-test|README|test-lib.sh|test-results|tmp.*|valgrind|corpus*|emacs.expected-output|smtp-dummy|smtp-dummy.c|test-verbose|test.expected-output|.*~)" | sort) +eval $(sed -n -e '/^TESTS="$/,/^"$/p' notmuch-test ../notmuch-test) +tests_in_suite=$(for i in $TESTS; do echo $i; done | sort) +available=$(ls -1 ../ | \ + sed -r -e "/^(aggregate-results.sh|Makefile|Makefile.local|notmuch-test)/d" \ + -e "/^(README|test-lib.sh|test-results|tmp.*|valgrind|corpus*)/d" \ + -e "/^(emacs.expected-output|smtp-dummy|smtp-dummy.c|test-verbose)/d" \ + -e "/^(test.expected-output|.*~)/d" | sort) test_expect_equal "$tests_in_suite" "$available" EXPECTED=../test.expected-output diff --git a/test/notmuch-test b/test/notmuch-test index fcf43a8..1e5ac11 100755 --- a/test/notmuch-test +++ b/test/notmuch-test @@ -16,7 +16,26 @@ fi cd $(dirname "$0") -TESTS="basic new search search-output search-by-folder json thread-naming raw reply dump-restore uuencode thread-order author-order from-guessing long-id encoding emacs maildir-sync" +TESTS=" + basic + new + search + search-output + search-by-folder + json + thread-naming + raw + reply + dump-restore + uuencode + thread-order + author-order + from-guessing + long-id + encoding + emacs + maildir-sync +" # Clean up any results from a previous run rm -r test-results >/dev/null 2>/dev/null -- 1.7.2.3