Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id B36C1431FC1 for ; Fri, 9 Apr 2010 06:01:11 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.301 X-Spam-Level: X-Spam-Status: No, score=-2.301 tagged_above=-999 required=5 tests=[BAYES_40=-0.001, RCVD_IN_DNSWL_MED=-2.3] autolearn=unavailable Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id I8LFDXzn8rXG for ; Fri, 9 Apr 2010 06:01:11 -0700 (PDT) Received: from ipex2.johnshopkins.edu (ipex2.johnshopkins.edu [162.129.8.151]) by olra.theworths.org (Postfix) with ESMTP id DFDF24196F0 for ; Fri, 9 Apr 2010 06:01:10 -0700 (PDT) X-IronPort-AV: E=Sophos;i="4.52,177,1270440000"; d="scan'208";a="319956787" Received: from unknown (HELO gogo) ([12.236.65.28]) by ipex2.johnshopkins.edu with ESMTP/TLS/AES256-SHA; 09 Apr 2010 09:01:09 -0400 Received: from jkr by gogo with local (Exim 4.69) (envelope-from ) id 1O0Elh-0000gV-BJ; Fri, 09 Apr 2010 10:01:09 -0400 From: Jesse Rosenthal To: Carl Worth , notmuch@notmuchmail.org Subject: Re: [notmuch] [PATCH v2] notmuch.el: Make notmuch-show buffer name first subject, instead of thread-id In-Reply-To: <87zl1f5f6u.fsf@yoom.home.cworth.org> References: <87zl1f5f6u.fsf@yoom.home.cworth.org> Date: Fri, 09 Apr 2010 10:01:09 -0400 Message-ID: <878w8wafoa.fsf@jhu.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Apr 2010 13:01:11 -0000 On Wed, 07 Apr 2010 10:46:01 -0700, Carl Worth wrote: > A very lovely change, Jesse! Thanks for this (which is now pushed). And > again, thanks to Sebastian for guiding the patch through the file > renaming. Great to hear! Sorry I've been off of email, and still only have sporadic access. However, one question: it looks like it was V2 of the patch that you pushed -- was it? Unfortunately, there was a subtle bug that kept on popping up (when you call notmuch-show interactively, which rarely happens). Later in this same thread, I offered V4 (yep, there was a problematic V3 too) which fixes this: id:876359cz16.fsf@jhu.edu Sorry for posting numerous versions. Quite embarassing. The only difference, as you'll see, is how it deals with the case when buffer-name is not given to notmuch-show as an argument. Thanks for all the pushes, and apologies for the trouble. Best, Jesse