From: Ethan Glasser-Camp <ethan.glasser.camp@gmail.com>
To: Pieter Praet <pieter@praet.org>, David Bremner <david@tethera.net>,
	Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
Subject: Re: [PATCH v2 4/6] emacs: add optional predicate arg to
	`notmuch-show-mapc'
In-Reply-To: <1330122640-18895-5-git-send-email-pieter@praet.org>
References: <87wr7xqpuf.fsf@rocinante.cs.unb.ca>
	<1330122640-18895-1-git-send-email-pieter@praet.org>
	<1330122640-18895-5-git-send-email-pieter@praet.org>
User-Agent: Notmuch/0.14+45~g6ea9330 (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Mon, 15 Oct 2012 22:18:12 -0400
Message-ID: <87r4oz88ij.fsf@betacantrips.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Notmuch Mail <notmuch@notmuchmail.org>
Precedence: list

Pieter Praet <pieter@praet.org> writes:

> * emacs/notmuch-show.el (notmuch-show-mapc):
>
>   If provided with optional argument PREDICATE, only call
>   FUNCTION if calling PREDICATE returns non-nil.
>
>   Also correct original docstring: 's/thread/buffer/'.
> ---

This patch was marked stale, but isn't.

> -(defun notmuch-show-mapc (function)
> -  "Iterate through all messages in the current thread with
> +(defun notmuch-show-mapc (function &optional predicate)
> +  "Iterate through all messages in the current buffer with
>  `notmuch-show-goto-message-next' and call FUNCTION for side
> -effects."
> +effects.
> +
> +If provided with optional argument PREDICATE, only call
> +FUNCTION if calling PREDICATE returns non-nil."
>    (save-excursion
>      (goto-char (point-min))
> -    (loop do (funcall function)
> +    (loop do (if predicate
> +		 (if (funcall predicate)
> +		     (funcall function))
> +	       (funcall function))

I don't like the way this if-structure looks, since I have to squint to
see whether the "else" clause matches the inner or the outer "if". Maybe
change the inner "if" to a "when" or an "and"?

Ethan