DomainKey-Signature: a=rsa-sha1; c=nofws; d=maillard.im; h=from:to
	:subject:in-reply-to:references:reply-to:date:message-id
	:mime-version:content-type; q=dns; s=postfix; b=zlaEHU7Vnd97yf7w
	I9vPORpC8pHYIfO6PwxyWb/C/6ia9KTNk5ot1yEgIIWxH6YKdjZ9aQFqWssLcnrl
	9I/6/Vp31s+HNxHHgp2JGy8Laqy6dorViGa9JzXGCQnKS2ea0O7IvjpQroisZUM8
	dpVRvGM0yhk6GnsXhpGJVBZUx4U=
From: Xavier Maillard <xavier@maillard.im>
To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH 10/10] test: use emacsclient(1) for Emacs tests
In-Reply-To: <1309236311-2162-10-git-send-email-dmitry.kurochkin@gmail.com>
References: <1309236311-2162-1-git-send-email-dmitry.kurochkin@gmail.com>
	<1309236311-2162-10-git-send-email-dmitry.kurochkin@gmail.com>
User-Agent: Notmuch/0.11 (http://notmuchmail.org) Emacs/23.2.1
	(i486-slackware-linux-gnu)
Date: Mon, 23 Jan 2012 20:08:59 +0100
Message-ID: <m27h0i2q44.fsf@kcals.intra.maillard.im>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list
Reply-To: Xavier Maillard <xma@gnu.org>

On Tue, 28 Jun 2011 08:45:11 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> Before the change, every Emacs test ran in a separate Emacs
> instance.  Starting Emacs many times wastes considerable time and
> it gets worse as the test suite grows.  The patch solves this by
> using a single Emacs server and emacsclient(1) to run multiple
> tests.  Emacs server is started on the first test_emacs call and
> stopped when test_done is called.  We take care not to leave
> orphan Emacs processes behind when test is terminated by whatever
> reason: Emacs server runs a watchdog that periodically checks
> that the test is still running.
> 
> Some tests need to provide user input.  Before the change, this
> was done using echo(1) to Emacs stdin.  This no longer works and
> instead `standard-input' variable is set accordingly to make
> `read' return the appropriate string.

I really like this too. 

+1

/Xavier