From: David Bremner <david@tethera.net>
To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH v2] completion: complete bash completion rewrite
In-Reply-To: <1362344368-27623-1-git-send-email-jani@nikula.org>
References: <1362232751-9571-1-git-send-email-jani@nikula.org>
	<1362344368-27623-1-git-send-email-jani@nikula.org>
User-Agent: Notmuch/0.15.1 (http://notmuchmail.org) Emacs/24.2.1
	(x86_64-pc-linux-gnu)
Date: Fri, 29 Mar 2013 09:28:00 -0400
Message-ID: <87zjxmwd27.fsf@maritornes.cs.unb.ca>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list

Jani Nikula <jani@nikula.org> writes:

> Rewrite the bash completion script to actually do something
> useful. Supported completions:
>
> * All the notmuch commands, command line arguments, and values for
>   keyword arguments.
It seems to do what it says on the box. The bash code look OK, although
I'm probably not as fussy or expert as some.

> ---
>
> CAVEATS:
>
> There may be dependencies on the version of the bash-completion
> package. I do not know, and I don't have a huge interest in finding
> out. That way lay dragons.

I pushed this.

Maybe we should just document what versions of bash-completion it is
tested with. I tested it with bash-completion 2.0. 

Could you make a followup patch with
something for completion/README and a line or so for NEWS?