From: Aaron Ecay <aaronecay@gmail.com>
To: Jameson Graef Rollins <jrollins@finestructure.net>,
	Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH 2/4] emacs: repurpose notmuch-show-archive-thread-internal
	function for general thread tagging
In-Reply-To: <87fwfnne02.fsf@servo.finestructure.net>
References: <1325975294-646-1-git-send-email-jrollins@finestructure.net>
	<1325975294-646-2-git-send-email-jrollins@finestructure.net>
	<1325975294-646-3-git-send-email-jrollins@finestructure.net>
	<m239bpk7h0.fsf@gmail.com> <87boqdr3mz.fsf@servo.finestructure.net>
	<m2obudii3n.fsf@gmail.com> <87fwfnne02.fsf@servo.finestructure.net>
User-Agent: Notmuch/0.10.1+56~gd709fd6 (http://notmuchmail.org)
	Emacs/24.0.92.1 (i386-apple-darwin10.8.0)
Date: Wed, 11 Jan 2012 00:53:35 -0500
Message-ID: <m2wr8yeqe8.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: list

On Tue, 10 Jan 2012 18:56:29 -0800, Jameson Graef Rollins <jrollins@finestr=
ucture.net> wrote:
> Actually, the show-next argument was already part of the function.  I
> did not introduce it.  And it wasn't optional originally, so if we want
> to change that behavior we should probably do so in a separate patch.

Hrm.  I didn=E2=80=99t communicate as clearly as I could have =E2=80=93 you=
 are correct
that the show-next argument to the notmuch-show-archive-internal function
was pre-existing.  But notmuch-show-tag-thread-internal is a new function,
with potentially expanded usefulness to third-party code.  Thus I think
I=E2=80=99m in the clear to bikeshed about its calling convention.  :) It=
=E2=80=99s your
patch, though, so it=E2=80=99s your call if you feel that the &optional goe=
s best
in a new change.

--=20
Aaron Ecay