Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 5878E429E21 for ; Mon, 23 Jan 2012 09:39:43 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.29 X-Spam-Level: X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9rK6hClSpqzS for ; Mon, 23 Jan 2012 09:39:42 -0800 (PST) Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu [131.215.239.19]) by olra.theworths.org (Postfix) with ESMTP id B58CC429E54 for ; Mon, 23 Jan 2012 09:39:42 -0800 (PST) Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1]) by earth-doxen-postvirus (Postfix) with ESMTP id 3532A66E0141; Mon, 23 Jan 2012 09:39:40 -0800 (PST) X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new Received: from finestructure.net (cpe-76-174-137-84.socal.res.rr.com [76.174.137.84]) (Authenticated sender: jrollins) by earth-doxen-submit (Postfix) with ESMTP id 5581466E0135; Mon, 23 Jan 2012 09:39:36 -0800 (PST) Received: by finestructure.net (Postfix, from userid 1000) id 9699634F; Mon, 23 Jan 2012 09:39:36 -0800 (PST) From: Jameson Graef Rollins To: David Edmondson , Notmuch Mail Subject: Re: [PATCH 4/6] emacs: add option to notmuch-show-next-open-message to pop out to parent buffer if at end In-Reply-To: References: <87pqea24z0.fsf@servo.finestructure.net> <1327307665-23387-1-git-send-email-jrollins@finestructure.net> <1327307665-23387-2-git-send-email-jrollins@finestructure.net> <1327307665-23387-3-git-send-email-jrollins@finestructure.net> <1327307665-23387-4-git-send-email-jrollins@finestructure.net> User-Agent: Notmuch/0.11+102~g958863a (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Mon, 23 Jan 2012 09:39:30 -0800 Message-ID: <87d3aa1fot.fsf@servo.finestructure.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jan 2012 17:39:43 -0000 --=-=-= Content-Transfer-Encoding: quoted-printable On Mon, 23 Jan 2012 11:02:04 +0000, David Edmondson wrote: > On Mon, 23 Jan 2012 00:34:23 -0800, Jameson Graef Rollins wrote: > > -(defun notmuch-show-next-open-message () > > +(defun notmuch-show-next-open-message (&optional pop-at-end) > > "Show the next message." > > - (interactive) > > - (let (r) > > + (interactive "P") > > + (let ((parent-buffer notmuch-show-parent-buffer) > > + (r)) >=20 > Extra brackets around 'r' are unnecessary. Otherwise, +1. This seems minor enough that I'm not going to resend, but noted for next time. Thanks. jamie. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBCAAGBQJPHZtSAAoJEO00zqvie6q8h2UQAKcQ2TVt08zZB7Cjl0tDLShU Md0TN+vB+iw5jVnqdgHl2CTmbHSN3Jgr7x1xHMu/bHb/HPtYzBamCkwBY6drr1bu Plfj36n7iNKSKJP98SM8iED0yZIbmVo52i9NG4n9Fc29gR+Zm9C8hfI0SpH4NtLH ZJ+IZw7qHCEg5RANsPloSrVe88dvaF12U7+Yo6OQ54M2G0lE3EjvSdzPN3NvL3UY N/0ucd/bsn6qyB21+3FCSA7KEV7YplgMnYdTZV8tT3jADHiqFZVShUEX0XVMlhWR /IHbS1kKD5g87+KNQZO2hzBN53DJIz3eVbwbOmfPHGVEG3bNaJhoaTzGWx3UMWPQ vks6LsZ9st1xJsMqabXvj41Cn7RCrb2zIwCTrJjM40BBwYkTFlWEY9JomeV3zPGn XBtZaMROyin7CI+gWrC4b3/nt/1KE8SSfgf5AdsxB9iobvVCBegiexYUdu1e7b+2 AOIxf5AyyNaRkiTNPbtT9HdCs/Mu0pdM1AlA0BOc5krH63q6InUOVUj9cDM/3mTo 2chqYbQqrPJy7E91w9yaLj7YDQU4sK+Iq86h3Hv1buSMTIWnI+gaLmoGS4PNJQxN A10pAUUx8IftVPSPmCITsvLOZojQRCuqCiJQpl0UuY95szTcr8U3XP5yDOuaDZY6 xE9f8YbwGD/e3IgyQ27H =brTb -----END PGP SIGNATURE----- --=-=-=--