From: Pieter Praet <pieter@praet.org>
To: Austin Clements <amdragon@MIT.EDU>
Subject: Re: [PATCH 4/4] setup: prompt user for search.exclude_tags value
In-Reply-To: <20120122170815.GO16740@mit.edu>
References: <1326586654-16840-3-git-send-email-amdragon@mit.edu>
	<1327000744-25463-1-git-send-email-pieter@praet.org>
	<1327000744-25463-5-git-send-email-pieter@praet.org>
	<20120119194437.GP16740@mit.edu> <8762g7o0k4.fsf@praet.org>
	<20120120041902.GV16740@mit.edu> <87ipk4446u.fsf@praet.org>
	<20120122170815.GO16740@mit.edu>
User-Agent: Notmuch/0.11+101~g94bf862 (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-unknown-linux-gnu)
Date: Mon, 23 Jan 2012 05:17:18 +0100
Message-ID: <87obtvaw8h.fsf@praet.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Notmuch Mail <notmuch@notmuchmail.org>
Precedence: list

On Sun, 22 Jan 2012 12:08:15 -0500, Austin Clements <amdragon@MIT.EDU> wrote:
> Quoth Pieter Praet on Jan 22 at  7:55 am:
> > On Thu, 19 Jan 2012 23:19:02 -0500, Austin Clements <amdragon@MIT.EDU> wrote:
> > > [...]
> > > Hah, okay.  How about this as an initial minor refactoring of the code
> > > for new.tags?
> > > [...]
> > 
> > Great, thanks!
> > 
> > 
> > Would the following commit message be satisfactory? :
> > 
> >   #+begin_quote
> >     setup: move tag printing and parsing into separate functions
> > 
> >     * notmuch-setup.c (notmuch_setup_command):
> >       Break tag printing and response parsing out into separate functions
> >       called `print_tag_list' respectively `parse_tag_list', for reuse
> >       with the 'search.exclude_tags' option.
> >   #+end_quote
> > 
> > (if not, please suggest an alternative; it'll be your name at the top)
> 
> Sure.

Great!

Updated patch series follows.


Peace

-- 
Pieter