Return-Path: <cworth@cworth.org>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 37833431FD0
	for <notmuch@notmuchmail.org>; Tue, 24 May 2011 13:33:36 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 0.01
X-Spam-Level: 
X-Spam-Status: No, score=0.01 tagged_above=-999 required=5
	tests=[T_MIME_NO_TEXT=0.01] autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 40pQiZvq1G8z for <notmuch@notmuchmail.org>;
	Tue, 24 May 2011 13:33:35 -0700 (PDT)
Received: from arlo.cworth.org (arlo.cworth.org [50.43.72.2])
	by olra.theworths.org (Postfix) with ESMTP id C7EE3431FB6
	for <notmuch@notmuchmail.org>; Tue, 24 May 2011 13:33:35 -0700 (PDT)
Received: from yoom.home.cworth.org (localhost [127.0.0.1])
	by arlo.cworth.org (Postfix) with ESMTP id 8C64A29A057;
	Tue, 24 May 2011 13:33:34 -0700 (PDT)
Received: by yoom.home.cworth.org (Postfix, from userid 1000)
	id 807DD25417E; Tue, 24 May 2011 13:33:34 -0700 (PDT)
From: Carl Worth <cworth@cworth.org>
To: Stewart Smith <stewart@flamingspork.com>,
 notmuch <notmuch@notmuchmail.org>
Subject: Re: [BUG] [PATCH] Fix appending of Received headers
In-Reply-To: <878vu6ulev.fsf@flamingspork.com>
References: <878vu6ulev.fsf@flamingspork.com>
User-Agent: Notmuch/0.5 (http://notmuchmail.org) Emacs/23.3.1
	(i486-pc-linux-gnu)
Date: Tue, 24 May 2011 13:33:25 -0700
Message-ID: <87ipszltyi.fsf@yoom.home.cworth.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Tue, 24 May 2011 20:33:36 -0000

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Tue, 17 May 2011 12:10:32 +1000, Stewart Smith <stewart@flamingspork.com=
> wrote:
> We're not properly concatenating the Received headers if we parse them
> while requesting a header that isn't Received.

Thanks, Stewart. The fix looks clearly correct.

> this fixes notmuch-reply address detection in a bunch of situations.

But can we go one step beyond "a bunch of situations"? Could you send a
message that demonstrates this bug? Or better yet, extend the
test/from-guessing test case to expose the bug?

I'd prefer to fix the test suite here so that we don't later regress on
this behavior.

Thanks,

=2DCarl

=2D-=20
carl.d.worth@intel.com

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEUEARECAAYFAk3cFhUACgkQ6JDdNq8qSWil4QCYsjOSQFECSvKGL+1KHSWEjG0w
IACfb5xVO2WiiqM1wKs7/sbviy0DjHQ=
=9pHV
-----END PGP SIGNATURE-----
--=-=-=--