To: Austin Clements <amdragon@MIT.EDU>
Subject: Re: [RFC][PATCH] notmuch: Workaround to allow ignoring non-void
	function return.
In-Reply-To: <20111222190305.GA324@mit.edu>
References: <1324503532-5799-1-git-send-email-dme@dme.org>
	<20111222070345.GI10376@mit.edu>
	<cunfwgdvzpy.fsf@hotblack-desiato.hh.sledj.net>
	<20111222190305.GA324@mit.edu>
User-Agent: Notmuch/0.10.2+107~ga2d0215 (http://notmuchmail.org)
	Emacs/24.0.92.1 (x86_64-pc-linux-gnu)
From: David Edmondson <dme@dme.org>
Date: Thu, 22 Dec 2011 19:25:59 +0000
Message-ID: <cuny5u4v260.fsf@hotblack-desiato.hh.sledj.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Cc: notmuch@notmuchmail.org
Precedence: list

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Thu, 22 Dec 2011 14:03:05 -0500, Austin Clements <amdragon@MIT.EDU> wrot=
e:
> > In general I agree, but what would we do if writing an error message to
> > stderr fails?
>=20
> This was discussed on IRC, but calls to write(2) should never be bare.
> I believe it's marked warn_unused_result not because libc is so
> concerned with people checking for error returns (otherwise all sorts
> of things would be marked warn_unused_result) but because even a
> successful write can be a short write.  Hence, not checking the result
> is a bug, even if you don't care about errors.

As I said, the principle is sound. What would do in this specific case?

static void
handle_sigint (unused (int sig))
{
    static char msg[] =3D "Stopping...         \n";

    write(2, msg, sizeof(msg)-1);
    interrupted =3D 1;
}

Just this?

     if (write(2, msg, sizeof(msg)-1) {
        /* Appease the compiler. */;
     }

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk7zhEcACgkQaezQq/BJZRb5sgCeKPmw3UKPGWKTOOdvLd++mdzi
awYAnRhOee2FLXQ5B/kilH9RWbxL/Nn6
=a06T
-----END PGP SIGNATURE-----
--=-=-=--