Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 99B4B429E54 for ; Sun, 22 Jan 2012 09:08:46 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vXDcAupU7lpN for ; Sun, 22 Jan 2012 09:08:44 -0800 (PST) Received: from dmz-mailsec-scanner-2.mit.edu (DMZ-MAILSEC-SCANNER-2.MIT.EDU [18.9.25.13]) by olra.theworths.org (Postfix) with ESMTP id AEB87429E40 for ; Sun, 22 Jan 2012 09:08:44 -0800 (PST) X-AuditID: 1209190d-b7fbf6d0000008ba-a0-4f1c429b33b3 Received: from mailhub-auth-4.mit.edu ( [18.7.62.39]) by dmz-mailsec-scanner-2.mit.edu (Symantec Messaging Gateway) with SMTP id 98.8A.02234.B924C1F4; Sun, 22 Jan 2012 12:08:43 -0500 (EST) Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id q0MH8haq017815; Sun, 22 Jan 2012 12:08:43 -0500 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) (authenticated bits=0) (User authenticated as amdragon@ATHENA.MIT.EDU) by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q0MH8fxl016228 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); Sun, 22 Jan 2012 12:08:42 -0500 (EST) Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77) (envelope-from ) id 1Rp0tr-0001iS-SM; Sun, 22 Jan 2012 12:08:15 -0500 Date: Sun, 22 Jan 2012 12:08:15 -0500 From: Austin Clements To: Pieter Praet Subject: Re: [PATCH 4/4] setup: prompt user for search.exclude_tags value Message-ID: <20120122170815.GO16740@mit.edu> References: <1326586654-16840-3-git-send-email-amdragon@mit.edu> <1327000744-25463-1-git-send-email-pieter@praet.org> <1327000744-25463-5-git-send-email-pieter@praet.org> <20120119194437.GP16740@mit.edu> <8762g7o0k4.fsf@praet.org> <20120120041902.GV16740@mit.edu> <87ipk4446u.fsf@praet.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87ipk4446u.fsf@praet.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpmleLIzCtJLcpLzFFi42IRYrdT153tJONvsGSvpcX1mzOZLX6/vsHs wOTxbNUtZo+OfZdZA5iiuGxSUnMyy1KL9O0SuDL+rH3DXtDBVnF99zv2BsaLLF2MnBwSAiYS K6dfYYawxSQu3FvP1sXIxSEksI9R4sCSE4wgCSGBDYwS/99YQ9gnmSROTK+FKFrCKLH0aRM7 SIJFQFWia9luMJtNQENi2/7lYM0iAsoSp5/8BIszC2hJbN34ASwuLOAp8XJ+G1icV0BHYuPF mYwQQ9cxSfybuY0NIiEocXLmExaY5hv/XjJ1MXIA2dISy/9xgIQ5BdQlXjzqAysXFVCRmHJy G9sERqFZSLpnIemehdC9gJF5FaNsSm6Vbm5iZk5xarJucXJiXl5qka6RXm5miV5qSukmRlBY c0ry7mB8d1DpEKMAB6MSD+/keGl/IdbEsuLK3EOMkhxMSqK8h6xl/IX4kvJTKjMSizPii0pz UosPMUpwMCuJ8Dp/BirnTUmsrEotyodJSXOwKInzqmq98xMSSE8sSc1OTS1ILYLJynBwKEnw fnIEGipYlJqeWpGWmVOCkGbi4AQZzgM0/AVIDW9xQWJucWY6RP4Uo6KUOC8vMHEICYAkMkrz 4HphaecVozjQK8K8DCBVPMCUBdf9CmgwE9BgjjwpkMEliQgpqQZGj9IJStLeoe8XN50/qveN /4aUwVapK845JZdLjhgFLlta7X/vyKEdH2Pz72q55C2e5lMouZM/bd0l+fZ1CQKNH68lhKcJ 6Aa4RLl8KV5mW3B4g9lmT+c5+ds+K9cEMrAahjyqjZqVPulEJ9/k339nv/B/y7o5ML/4LNe/ zub8e7L5XxJeM3orsRRnJBpqMRcVJwIAzVZnWxYDAAA= Cc: Notmuch Mail X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Jan 2012 17:08:46 -0000 Quoth Pieter Praet on Jan 22 at 7:55 am: > On Thu, 19 Jan 2012 23:19:02 -0500, Austin Clements wrote: > > [...] > > Hah, okay. How about this as an initial minor refactoring of the code > > for new.tags? > > [...] > > Great, thanks! > > > Would the following commit message be satisfactory? : > > #+begin_quote > setup: move tag printing and parsing into separate functions > > * notmuch-setup.c (notmuch_setup_command): > Break tag printing and response parsing out into separate functions > called `print_tag_list' respectively `parse_tag_list', for reuse > with the 'search.exclude_tags' option. > #+end_quote > > (if not, please suggest an alternative; it'll be your name at the top) Sure.