Return-Path: <dmitry.kurochkin@gmail.com>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 37DC5429E25
	for <notmuch@notmuchmail.org>; Sun, 11 Dec 2011 02:34:57 -0800 (PST)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: -0.799
X-Spam-Level: 
X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
	tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
	FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id OQlkweQgBCTm for <notmuch@notmuchmail.org>;
	Sun, 11 Dec 2011 02:34:56 -0800 (PST)
Received: from mail-bw0-f53.google.com (mail-bw0-f53.google.com
	[209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
	(No client certificate requested)
	by olra.theworths.org (Postfix) with ESMTPS id 9E6CE431FB6
	for <notmuch@notmuchmail.org>; Sun, 11 Dec 2011 02:34:56 -0800 (PST)
Received: by bkat8 with SMTP id t8so4707026bka.26
	for <notmuch@notmuchmail.org>; Sun, 11 Dec 2011 02:34:53 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=from:to:subject:in-reply-to:references:user-agent:date:message-id
	:mime-version:content-type;
	bh=VNP2MMS6gPDFhxq3/X8GIr0NjM9p+nwX2SVxYJfhB5M=;
	b=MgOkMw8/P9FtlmDHmd0ub/GcLI4dLuCRl9J5FKb4Mzpl9mVVcmAWL00H6rwxP8gZlR
	0WjxcIeuduAHbnUmxCyQkj26qRnMTEYsWxIHCDCc5WJEL4yPY8MrL+QYGXxseycy6ebh
	P1n4qrDo3WplW8PZeqkBGJM+m2uyZsH5qLmT4=
Received: by 10.204.155.150 with SMTP id s22mr1401922bkw.140.1323599693718;
	Sun, 11 Dec 2011 02:34:53 -0800 (PST)
Received: from localhost ([91.144.186.21])
	by mx.google.com with ESMTPS id d2sm22884304bky.11.2011.12.11.02.34.51
	(version=TLSv1/SSLv3 cipher=OTHER);
	Sun, 11 Dec 2011 02:34:52 -0800 (PST)
From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
Subject: Re: [PATCH 4/4] show: Rewrite show_message_body to use the MIME tree
	interface.
In-Reply-To: <1323460468-4030-5-git-send-email-amdragon@mit.edu>
References: <1323027100-10307-1-git-send-email-amdragon@mit.edu>
	<1323460468-4030-1-git-send-email-amdragon@mit.edu>
	<1323460468-4030-5-git-send-email-amdragon@mit.edu>
User-Agent: Notmuch/0.10.2+82~g96a629c (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Sun, 11 Dec 2011 14:34:18 +0400
Message-ID: <87ehwb75xx.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Sun, 11 Dec 2011 10:34:57 -0000

Hi Austin.

I enjoyed reviewing this patch.  It is a pleasure to see how complex and
confusing code becomes much smaller and cleaner.

I still have some questions with the new code.  It seems confusing to me
that part_content is called first and then go envelope headers.  But I
this is just the first step of the rewrite, right? :)

The only comment I have:

+    format->part_content (part);

For all other format members that are function pointers, we have a check
for NULL.  Perhaps we should add it here as well?

Regards,
  Dmitry