Return-Path: <Vladimir.Marek@Oracle.COM>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 5D7BC431FBC
	for <notmuch@notmuchmail.org>; Sun, 12 May 2013 13:22:01 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: -2.299
X-Spam-Level: 
X-Spam-Status: No, score=-2.299 tagged_above=-999 required=5
	tests=[RCVD_IN_DNSWL_MED=-2.3, UNPARSEABLE_RELAY=0.001]
	autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id tsk6SoXFJHZ6 for <notmuch@notmuchmail.org>;
	Sun, 12 May 2013 13:21:55 -0700 (PDT)
Received: from userp1040.oracle.com (userp1040.oracle.com [156.151.31.81])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by olra.theworths.org (Postfix) with ESMTPS id 302B7431FAE
	for <notmuch@notmuchmail.org>; Sun, 12 May 2013 13:21:55 -0700 (PDT)
Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93])
	by userp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with
	ESMTP id r4CKLoNL011269
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);
	Sun, 12 May 2013 20:21:51 GMT
Received: from aserz7021.oracle.com (aserz7021.oracle.com [141.146.126.230])
	by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id
	r4CKLoH4013696
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL);
	Sun, 12 May 2013 20:21:50 GMT
Received: from abhmt116.oracle.com (abhmt116.oracle.com [141.146.116.68])
	by aserz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id
	r4CKLnMw029046; Sun, 12 May 2013 20:21:49 GMT
Received: from vi64-x3-2e-prg06.cz.oracle.com (/10.163.102.127)
	by default (Oracle Beehive Gateway v4.0)
	with ESMTP ; Sun, 12 May 2013 13:21:49 -0700
Date: Sun, 12 May 2013 22:21:45 +0200
From: Vladimir Marek <Vladimir.Marek@Oracle.COM>
To: Jani Nikula <jani@nikula.org>
Subject: Re: Solaris support - missing or incompatible functions
Message-ID: <20130512202145.GA2047@vi64-x3-2e-prg06.cz.oracle.com>
References: <1367853362-11846-1-git-send-email-Vladimir.Marek@oracle.com>
	<87ehdc9dbh.fsf@nikula.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <87ehdc9dbh.fsf@nikula.org>
User-Agent: Mutt/ (2012-12-30)
X-Source-IP: ucsinet21.oracle.com [156.151.31.93]
Cc: notmuch@notmuchmail.org
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Sun, 12 May 2013 20:22:01 -0000

> > I can't run the notmuch 'make test' on Solaris (too old bash) and on linux the
> > results are
> >
> > 421/525 tests passed.
> > 25 tests failed.
> > 79 tests skipped.
> >
> > but they are the same without my changes too ...
> 
> The series LGTM, except I didn't pay much attention to the timegm()
> implementation. I hope the time parsing tests pass though. If they do,
> and you think the implementation is good enough, then who am I to
> argue. ;)


I didn't pay too much attention to the test output as it's broken on
linux too :)

Thank you
-- 
	Vlad