From: =?utf-8?q?Amadeusz_=C5=BBo=C5=82nowski?= <aidecoe@aidecoe.name>
To: David Bremner <david@tethera.net>
Subject: Re: [PATCH 1/2] Build symbol-test with make instead of hardcoding in
	symbol-hiding.
In-reply-to: <878vn4bbf7.fsf@convex-new.cs.unb.ca>
References: <1322218492-8300-1-git-send-email-aidecoe@aidecoe.name>
	<878vn4bbf7.fsf@convex-new.cs.unb.ca>
Date: Fri, 25 Nov 2011 16:12:24 +0100
Message-Id: <1322233411-sup-6651@ittemni>
User-Agent: Sup/git
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Content-Type: multipart/signed; protocol="application/pgp-signature";
	boundary="=-1322233944-445180-28641-4206-1-="
Cc: notmuch <notmuch@notmuchmail.org>
Precedence: list


--=-1322233944-445180-28641-4206-1-=
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Excerpts from David Bremner's message of 2011-11-25 14:04:44 +0100:
> On Fri, 25 Nov 2011 11:54:51 +0100, Amadeusz =C5=BBo=C5=82nowski <aidec=
oe@aidecoe.name> wrote:
> >  =

> > +$(dir)/symbol-test: $(dir)/symbol-test.o
> > +    $(call quiet,CC) $^ -o $@ -Llib -lnotmuch -lxapian
> =

> I'm a bit surprised no -I is neaded here. Is that taken care in the CC
> call?

-I is for headers which are not used when linking.  symbol-test.o is
compiled according to rule defined earlier in some parent Makefile.


> >  .PHONY: test check
> > -test:    all $(dir)/smtp-dummy
> > +test:    all $(dir)/smtp-dummy $(dir)/symbol-test
> >      @${dir}/notmuch-test $(OPTIONS)
> =

> The instructions were already wrong, but maybe they should be updated t=
o
> point out that calling the test scripts directly requires smtp-dummy an=
d
> symbol-test already be built. Or maybe the tests should check for these=

> binaries as pre-reqs along with emacs, gpg, etc... =

> =

> > +       -e "/^(emacs.expected-output|smtp-dummy|smtp-dummy.c|test-ver=
bose|symbol-test.cc|symbol-test|symbol-test.o)/d" \
> =

> I wonder if this should be shortened (and made a bit sloppier) with the=

> use of regexes.

Thanks it's so straightforward.  I found this line quickly without deep
analysis of all test-framework. :-)  It could only be made more flexible
- put list of this files into some separate text file.  But that's
subject for another patch.  Purpose of this one is to make building out
of tree working.


--
Amadeusz =C5=BBo=C5=82nowski

--=-1322233944-445180-28641-4206-1-=
Content-Disposition: attachment; filename="signature.asc"
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.18 (GNU/Linux)

iQEcBAEBAgAGBQJOz7BYAAoJEPATRTHh2/q1sJUIAIBRHA27PddyBEm/+xYFQp+m
3m6AkOBNtxjZ11DOxFD5Yva98De3/mmwnvn0xCj9DcRT+lXZamxE1BU22TouxMRx
J7FFuUVX1DP9EJPnGfc3P0ZKlcEGWKKLSSL0lt38IoWEK4mmUY/XjTSuhh8B5v/4
+0T7pWeU/TBS0U7pEr/z2AtzODq9PMP771BzHGzrevIeDul3RJ390g55h5Vlo5oa
jYELaqPSx5C2tuLzBWJ0LVhDGVRtp/YpQw973ltKJz4vyPgU87h4AjNYvj8CYj/B
qsX15qljqbNnGK8WeRKH2poKLCVFrG9OpXvhYX4UWBuXuRxiVqBil+eFxfLVR0E=
=d64X
-----END PGP SIGNATURE-----

--=-1322233944-445180-28641-4206-1-=--