Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 08F62431FBF for ; Wed, 25 Nov 2009 11:55:22 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KZjmmLZs+R3I for ; Wed, 25 Nov 2009 11:55:21 -0800 (PST) Received: from tau.jukie.net (tau.jukie.net [216.239.93.128]) by olra.theworths.org (Postfix) with ESMTP id 41568431FAE for ; Wed, 25 Nov 2009 11:55:21 -0800 (PST) Received: by tau.jukie.net (Postfix, from userid 1000) id 9A526C0090B; Wed, 25 Nov 2009 14:55:20 -0500 (EST) Date: Wed, 25 Nov 2009 14:55:20 -0500 From: Bart Trojanowski To: Jan Janak Message-ID: <20091125195520.GG29312@jukie.net> References: <1259100630-13673-5-git-send-email-jan@ryngle.com> <1259174251-27298-1-git-send-email-jan@ryngle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1259174251-27298-1-git-send-email-jan@ryngle.com> User-Agent: Mutt/1.5.18 (2008-05-17) Cc: notmuch@notmuchmail.org Subject: Re: [notmuch] [PATCH] notmuch-new: Option to disable tags from the configuration file. X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Nov 2009 19:55:22 -0000 Jan, I think your use of STRNCMP_LITERAL here is wrong... > + } else if (STRNCMP_LITERAL (argv[i], "--no-config-tags") == 0) { > + add_config_tags = 0; it will happily match "--no-config-tags-xxxxxxxxxxxxxxxxxxx". Can I also suggest including --no-config-tags in the 'notmuch help' output? Besides that I am very happy with this patch series. -pBart -- WebSig: http://www.jukie.net/~bart/sig/