Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 17D72431FD0 for ; Mon, 27 Jun 2011 10:07:53 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.29 X-Spam-Level: X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=unavailable Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id i-9Wj99FOppa for ; Mon, 27 Jun 2011 10:07:53 -0700 (PDT) Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu [131.215.239.19]) by olra.theworths.org (Postfix) with ESMTP id E3176431FB6 for ; Mon, 27 Jun 2011 10:07:52 -0700 (PDT) Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1]) by earth-doxen-postvirus (Postfix) with ESMTP id D4DBA66E013C; Mon, 27 Jun 2011 10:07:48 -0700 (PDT) X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new Received: from servo.finestructure.net (cpe-98-149-172-122.socal.res.rr.com [98.149.172.122]) (Authenticated sender: jrollins) by earth-doxen-submit (Postfix) with ESMTP id D9D5366E00EB; Mon, 27 Jun 2011 10:07:45 -0700 (PDT) Received: by servo.finestructure.net (Postfix, from userid 1000) id A8AD8178; Mon, 27 Jun 2011 10:07:46 -0700 (PDT) From: Jameson Graef Rollins To: Carl Worth , Notmuch Mail Subject: Re: [PATCH] Do not attept to output part raw if part is not GMimePart. In-Reply-To: <87wrgccedd.fsf@yoom.home.cworth.org> References: <1307032735-27427-1-git-send-email-jrollins@finestructure.net> <1307120466-4980-1-git-send-email-jrollins@finestructure.net> <87wrgccedd.fsf@yoom.home.cworth.org> User-Agent: Notmuch/0.5-292-gaa2fa19 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Mon, 27 Jun 2011 10:07:44 -0700 Message-ID: <87mxh319un.fsf@servo.factory.finestructure.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jun 2011 17:07:53 -0000 --=-=-= Content-Transfer-Encoding: quoted-printable On Thu, 23 Jun 2011 16:33:18 -0700, Carl Worth wrote: > I'd like to investigate this case a little bit to help answer the > question of whether "notmuch should have done anything in this case". Hi, Carl. You can see this error if you try to output raw a multipart/* or message/rfc822 part, ie: servo:~ 0$ notmuch show --part=3D1 --format=3Draw id:"87wrgccedd.fsf@yoom.h= ome.cworth.org" >/dev/null (process:29838): GLib-GObject-WARNING **: invalid cast from `GMimeMultipart= Signed' to `GMimePart' (process:29838): gmime-CRITICAL **: g_mime_part_get_content_object: asserti= on `GMIME_IS_PART (mime_part)' failed servo:~ 0$=20 Gmime seems to be successfully casting the part into GMimePart and then outputting the content, but it does produce the warning on stderr. jamie. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBCAAGBQJOCLjgAAoJEO00zqvie6q8kwQQALreoHwaw/25vOCFbKu/x/2j PhtKze6U3Ks2CJ43jmpCa7aXQ2/2m5axoOPioXA7SDsUUgIm7lQ0gMNy1fa2iLKg tjqnjpSAlbJrSY6J9b5+d3vU3QOpl42y0fLWSFijTXbKqMN/8vxmEx910fQ78b5P f9wM9r9pR5/ocVZB7l01+c12D7uLJ+KySTbReC0zZJqBCM16Gi35SE7XAuUauTbx Kr/y2WQdFtOTVd1j46PekFw70QOwRmvBeonxeluEbNsU9fVhtI507tItI85TSKaa +Ym5dlAf0wqsFY8YobnQQwQdNGwh5vRm635WpUEI0rE8kSuYt2r2LhXamRksjJfx FIo4vlc34soAACMssYlqJxnLurE1ytRObXOaTaYe+FzhQyz/hwBULMd8PsINEmJy RICOrQ2Le/FGSqBMHMUGqWU6CcSMixc6ySm8dm1kOKwgjeLB5R5iQKxehvUpU9vW L4Jc7dYKXskcIEJRTBqHzUBozMM7TNfUYQ4ciyVd8RtETy21b7wH7ogfTK9aU4zM jipXtD7w1AmpzNAod/vjeESBAy14U+59wrskuJf0eyNOwNYIu7nnUqU+EnMaZMr/ W74mY99IW+8joJwUimg8kZvvl9CQCIU01dS9j1a0bTdpuKb8kcHOBKRqdIaf1wZc 4cU0mcPn62h34Kb4EhEM =FHql -----END PGP SIGNATURE----- --=-=-=--