From: Mark Walters <markwalters1009@gmail.com>
To: Sam Halliday <sam.halliday@gmail.com>, notmuch@notmuchmail.org
Subject: Re: use font-face instead of explicit colouring
In-Reply-To: <87k2lhmecn.fsf@gmail.com>
References: <87mvqdmer2.fsf@gmail.com> <87k2lhmecn.fsf@gmail.com>
User-Agent: Notmuch/0.18.1+485~gca076ce (http://notmuchmail.org) Emacs/24.4.1
 (x86_64-pc-linux-gnu)
Date: Sat, 05 Mar 2016 11:00:00 +0000
Message-ID: <87h9glb367.fsf@qmul.ac.uk>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list


Hi

On Sat, 05 Mar 2016, Sam Halliday <sam.halliday@gmail.com> wrote:
> I should say that I am aware of the workaround, e.g.
>
>     (setq
>       notmuch-search-line-faces '(("unread" :weight bold)
>                                   ("flagged" :inherit 'font-lock-string-face)))
>
> but this must be applied per-user. If you removed this defcustom and had
> unread/flagged/other faces, then themes (such as darcula) would be able
> to provide sensible defaults out of the box.

I am not sure I see how this would work without cluttering up the
customize options significantly. The notmuch-search-line-faces allows
selecting the face based on any tag (so for example I use different
colours for emails tagged "work", and tagged "waiting"). We could have
additional notmuch-search-line-unread-face which could then be  used in
the above -- but now the user has two places to customize the same thing.

How do you see this working?

(We probably could make the default depend on light or dark theme to make
the default more usable.)

Best wishes

Mark

>
> Sam Halliday <sam.halliday@gmail.com> writes:
>
>> [ text/plain ]
>> Hi,
>>
>> I use a dark theme and many of the colour choices of notmuch collide
>> with my theme. However, notmuch is explicitly adding information such as
>> "blue foreground" instead of using faces that I can customise.
>>
>> Could you please consider using faces instead of explicit colours?
>>
>> [ text/plain ]
>>
>> -- 
>> Best regards,
>> Sam
>> [ signature.asc: application/pgp-signature ]
>
> -- 
> Best regards,
> Sam
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch