Return-Path: <amdragon@mit.edu>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 02DE7431FAF
	for <notmuch@notmuchmail.org>; Fri, 20 Jan 2012 08:34:15 -0800 (PST)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: -0.7
X-Spam-Level: 
X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
	tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id YHb3dHVwyWR0 for <notmuch@notmuchmail.org>;
	Fri, 20 Jan 2012 08:34:14 -0800 (PST)
Received: from dmz-mailsec-scanner-8.mit.edu (DMZ-MAILSEC-SCANNER-8.MIT.EDU
	[18.7.68.37])
	by olra.theworths.org (Postfix) with ESMTP id 59ACD431FAE
	for <notmuch@notmuchmail.org>; Fri, 20 Jan 2012 08:34:14 -0800 (PST)
X-AuditID: 12074425-b7f4a6d0000008e0-36-4f19978588bb
Received: from mailhub-auth-1.mit.edu ( [18.9.21.35])
	by dmz-mailsec-scanner-8.mit.edu (Symantec Messaging Gateway) with SMTP
	id 70.F3.02272.587991F4; Fri, 20 Jan 2012 11:34:13 -0500 (EST)
Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])
	by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id q0KGYCrk017105; 
	Fri, 20 Jan 2012 11:34:13 -0500
Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])
	(authenticated bits=0)
	(User authenticated as amdragon@ATHENA.MIT.EDU)
	by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q0KGYAHH028708
	(version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);
	Fri, 20 Jan 2012 11:34:12 -0500 (EST)
Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)
	(envelope-from <amdragon@mit.edu>)
	id 1RoHPS-00068c-UX; Fri, 20 Jan 2012 11:33:50 -0500
Date: Fri, 20 Jan 2012 11:33:50 -0500
From: Austin Clements <amdragon@MIT.EDU>
To: Thomas Jost <schnouki@schnouki.net>
Subject: Re: [PATCH v4 2/3] Add compatibility with gmime 2.6
Message-ID: <20120120163334.GX16740@mit.edu>
References: <87fwfaemuc.fsf@thor.loria.fr>
	<1327052365-20012-1-git-send-email-schnouki@schnouki.net>
	<1327052365-20012-2-git-send-email-schnouki@schnouki.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1327052365-20012-2-git-send-email-schnouki@schnouki.net>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Brightmail-Tracker:
 H4sIAAAAAAAAA+NgFmpkleLIzCtJLcpLzFFi42IR4hRV1m2dLulv8GiqhcX1mzOZLfb1+zsw
	eTxbdYvZY8qsuewBTFFcNimpOZllqUX6dglcGWvb9rIVzGet+LfEqoFxAUsXIyeHhICJROf2
	+2wQtpjEhXvrgWwuDiGBfYwS/w8/BysSEtjAKHHiRCpE4iSTxNVzK1kgnCVAVV9/MncxcnCw
	CKhKrHheC9LAJqAhsW3/ckYQW0RAXaJh/m6wDcwC0hLffjczgdjCAjYSnUe7mEFsXgEdiZNn
	n7BCzFwEtOzibFaIhKDEyZlPWCCatSRu/HvJBLILZNDyfxwgYU4BN4mvd3eAzRQVUJGYcnIb
	2wRGoVlIumch6Z6F0L2AkXkVo2xKbpVubmJmTnFqsm5xcmJeXmqRroVebmaJXmpK6SZGUEiz
	u6juYJxwSOkQowAHoxIPL7erhL8Qa2JZcWXuIUZJDiYlUd4PUyT9hfiS8lMqMxKLM+KLSnNS
	iw8xSnAwK4nwlnUB5XhTEiurUovyYVLSHCxK4ryaWu/8hATSE0tSs1NTC1KLYLIyHBxKErya
	wNgVEixKTU+tSMvMKUFIM3FwggznARr+bhrI8OKCxNzizHSI/ClGRSlx3g8gCQGQREZpHlwv
	LOW8YhQHekWYlwFkBQ8wXcF1vwIazAQ02KNJDGRwSSJCSqqBscRy7/yWJ2teqK45VF7Y5PDu
	oJvJKr19RyR+3/jvdtFx/aROhl7pzXV7z4aa3j22xvHrg+LY+KfiPYVpayduVTA9IJO59IBZ
	QtzBXKND6xP5mwsKP56qeHpqipWd69EG/pJidbb3SRNe1U5O/LprrXVQ6/Mtd7Y1Krs++Jfc
	s5R1XvIVfu3Hp5VYijMSDbWYi4oTAcsFbTsUAwAA
Cc: notmuch@notmuchmail.org
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Jan 2012 16:34:15 -0000

LGTM!

Quoth Thomas Jost on Jan 20 at 10:39 am:
> There are lots of API changes in gmime 2.6 crypto handling. By adding
> preprocessor directives, it is however possible to add gmime 2.6 compatibility
> while preserving compatibility with gmime 2.4 too.
> 
> This is mostly based on id:"8762i8hrb9.fsf@bookbinder.fernseed.info".
> 
> This was tested against both gmime 2.6.4 and 2.4.31. With gmime 2.4.31, the
> crypto tests all work fine (as expected). With gmime 2.6.4, one crypto test is
> currently broken (signature verification with signer key unavailable), most
> likely because of a bug in gmime which will hopefully be fixed in a future
> version.