From: Carl Worth <cworth@cworth.org>
To: Aaron Ecay <aaronecay@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH 3/4] Add infrastructure for building shared library on OS
	X.
In-Reply-To: <87sk6xgbft.fsf@yoom.home.cworth.org>
References: <4bc25ea0.86c3f10a.45a3.ffff80d3@mx.google.com>
	<1271029494-89014-3-git-send-email-aaronecay@gmail.com>
	<87sk6xgbft.fsf@yoom.home.cworth.org>
Date: Wed, 14 Apr 2010 16:39:27 -0700
Message-ID: <87ljcpfvtc.fsf@yoom.home.cworth.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Precedence: list

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Wed, 14 Apr 2010 11:01:58 -0700, Carl Worth <cworth@cworth.org> wrote:
> > +printf "Checking for Mac OS X (for shared library)... "
> > +if [ `uname` =3D "Darwin" ] ; then
> > +    printf "Yes.\n"
> > +    mac_os_x=3D1
> > +else
> > +    printf "No.\n"
> > +    mac_os_x=3D0
> > +fi
> > +
>=20
> Instead of inventing a new mac_os_x variable, we should follow the GNU
> configure conventions of build_cpu, build_vendor, build_os
> variables.

I've gone ahead and pushed the above. We can still fix to use build_os
internally instead of mac_os_x, but that's fairly cosmetic.

I also pushed out my own version of the fix for FINAL_NOTMUCH_LDFLAGS,
(which does the extra linking on OS X, but not Linux).

Please, anyone that's interested, test notmuch on your favorite
platforms and let us know what's still broken. I did do a little testing
and research with the OS X machine I could find here, but I'm no expert,
nor do I have access to many other systems.

=2DCarl

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iD8DBQFLxlIv6JDdNq8qSWgRAih0AJwPO1D4vlKP8F1y+7Q3NqjnEuGpwgCfbzPj
tw4CLEKWtURaNX6L4AucTg0=
=SC3o
-----END PGP SIGNATURE-----
--=-=-=--