From: Ethan Glasser-Camp <ethan.glasser.camp@gmail.com>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH 1/3] contrib: add notmuch-pick.el file itself
In-Reply-To: <1351337200-18050-2-git-send-email-markwalters1009@gmail.com>
References: <1351337200-18050-1-git-send-email-markwalters1009@gmail.com>
	<1351337200-18050-2-git-send-email-markwalters1009@gmail.com>
User-Agent: Notmuch/0.14+45~g6ea9330 (http://notmuchmail.org) Emacs/23.4.1
	(x86_64-pc-linux-gnu)
Date: Sat, 27 Oct 2012 13:39:04 -0400
Message-ID: <87txtfhl1j.fsf@betacantrips.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list

Mark Walters <markwalters1009@gmail.com> writes:

> +(defvar notmuch-pick-json-parser nil
> +  "Incremental JSON parser for the search process filter.")
> +
> +(defun notmuch-pick-process-filter (proc string)
> +  "Process and filter the output of \"notmuch show\" (for pick)"
> +  (let ((results-buf (process-buffer proc))
> +        (parse-buf (process-get proc 'parse-buf))
> +        (inhibit-read-only t)
> +        done)
> +    (if (not (buffer-live-p results-buf))
> +        (delete-process proc)
> +      (with-current-buffer parse-buf
> +        ;; Insert new data
> +        (save-excursion
> +          (goto-char (point-max))
> +          (insert string)))
> +      (with-current-buffer results-buf
> +	(save-excursion
> +	  (goto-char (point-max))
> +	  (while (not done)
> +	    (condition-case nil
> +		(case notmuch-pick-process-state

This looks awfully familiar. Not looking too close, but why can't this
re-use the JSON parser from your other patch? Just not to rely on the
other patch series?

Still, let's get this pushed.

Ethan