From: Carl Worth <cworth@cworth.org>
To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
Subject: Re: [PATCH] new: Improved workaround for mistaken new directories
In-Reply-To: <1309388401-16437-1-git-send-email-amdragon@mit.edu>
References: <1309388401-16437-1-git-send-email-amdragon@mit.edu>
User-Agent: Notmuch/0.5 (http://notmuchmail.org) Emacs/23.3.1
	(i486-pc-linux-gnu)
Date: Wed, 29 Jun 2011 16:13:05 -0700
Message-ID: <87d3hw44fy.fsf@yoom.home.cworth.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Cc: amdragon@mit.edu
Precedence: list

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Wed, 29 Jun 2011 19:00:01 -0400, Austin Clements <amdragon@MIT.EDU> wrot=
e:
> We work around this by setting the new directory's database mtime to
> -1 before scanning anything in the new directory.  This also obviates
> the need for the workaround used in 8c39e8d6.

Thanks. This is pushed.

> +    /* XXX This is a temporary workaround.  If we don't update the
> +     * database mtime until after processing messages in this
...
> +     * A better solution would be for notmuch_database_get_directory
> +     * to indicate if it really created a new directory or not, either
> +     * by a new out-argument, or by recording this information and
> +     * providing an accessor.

A much better "XXX" comment! It tells the potential reader of the future
what to do to be able to remove the comment. Thanks so much.

=2DCarl

=2D-=20
carl.d.worth@intel.com

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk4LsYEACgkQ6JDdNq8qSWgW2gCeJ3fMpL6YUU0egCkohBBp06mD
rQsAnikdmdOH0hJNpi91z1uqfTbUbXGX
=iN0W
-----END PGP SIGNATURE-----
--=-=-=--