DomainKey-Signature: a=rsa-sha1; c=nofws; d=maillard.im; h=from:to
	:subject:in-reply-to:references:reply-to:date:message-id
	:mime-version:content-type; q=dns; s=postfix; b=Wxp9ggefZagjBizs
	fO8vVtldApVHEOf+D9OyXZrP6WWUa2F3FpjYX5FQwauQMniXlhgkOkBJ+n7VMXe5
	VHtwpoAaAycNX/zCqZuFYrBCjREjI2yqQKhKFUEWFEQsbLPtYz7JPisq4r9Kz5EB
	mZBmwzhtQjOtnPB5RWzeB0sjoMk=
From: Xavier Maillard <xavier@maillard.im>
To: Carl Worth <cworth@cworth.org>, Matthieu Lemerre <racin@free.fr>,
	notmuch@notmuchmail.org
Subject: Re: Warning when GMime is parsing broken email addresses
In-Reply-To: <877hai3r82.fsf@yoom.home.cworth.org>
References: <87ipzvk2xh.fsf@free.fr> <877hai3r82.fsf@yoom.home.cworth.org>
User-Agent: Notmuch/0.5-133-gc509598 (http://notmuchmail.org) Emacs/23.2.1
	(i486-slackware-linux-gnu)
Date: Wed, 27 Apr 2011 18:30:09 +0200
Message-ID: <m2y62vy7vy.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list
Reply-To: Xavier Maillard <xma@gnu.org>

On Mon, 25 Apr 2011 15:23:41 -0700, Carl Worth <cworth@cworth.org> wrote:
> On Wed, 17 Nov 2010 23:20:26 +0100, Matthieu Lemerre <racin@free.fr> wrote:
> > Maybe it would also be interesting to add a warning/assertion to check
> > that all email adresses added to the database are correct email
> > addresses? I.e. check that the `addr' variable in _index_address_mailbox
> > always has a @. This check is in fact already done using the function
> > strchr, but a bad value is explicitly ignored...
> 
> Hmm... we could add a warning like that. But I don't know how useful it
> would actually be. (I, for one, am currently not seeing any warnings
> From "notmuch new"---maybe I should fix that...).
> 
> Since GMime is fixed upstream (as of version 2.4.18) another option
> would be to simply make the notmuch build system require a sufficiently
> new version of GMime in order to build.
> 
> What do you think?

My vote goes to the latter. Cleaner and really simple solution.

/Xavier