Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 1753F418C34 for ; Mon, 26 Apr 2010 09:25:47 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -4.2 X-Spam-Level: X-Spam-Status: No, score=-4.2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3] autolearn=ham Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6GWxgESM4N44 for ; Mon, 26 Apr 2010 09:25:46 -0700 (PDT) Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) by olra.theworths.org (Postfix) with ESMTP id 6AABB431FC1 for ; Mon, 26 Apr 2010 09:25:46 -0700 (PDT) Received: from localhost ([::1] helo=x200.gr8dns.org) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1O6R7y-0003mU-01; Mon, 26 Apr 2010 16:25:46 +0000 Received: by x200.gr8dns.org (Postfix, from userid 500) id F0458CC839; Mon, 26 Apr 2010 09:25:45 -0700 (PDT) From: Dirk Hohndel To: David Edmondson , notmuch Subject: Re: [PATCH] RFC: Add From guessing when forwarding email In-Reply-To: <87och65w9q.fsf@ut.hh.sledj.net> References: <87och65w9q.fsf@ut.hh.sledj.net> User-Agent: Notmuch/0.2-215-g399f248 (http://notmuchmail.org) Emacs/23.1.1 (i386-redhat-linux-gnu) Date: Mon, 26 Apr 2010 09:25:45 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Apr 2010 16:25:47 -0000 On Mon, 26 Apr 2010 11:43:45 +0100, David Edmondson wrote: > On Fri, 23 Apr 2010 15:52:15 -0700, Dirk Hohndel wrote: > > Given how little elisp I know I'm quite interested in feedback > > and better implementations > > I think that: > > (defun notmuch-show-forward-message () > "Forward the current message." > (interactive) > (let ((user-mail-address > (shell-command-to-string (concat notmuch-command > "guess-from" > (notmuch-show-get-message-id))))) > (with-current-notmuch-show-message > (notmuch-mua-forward-message)))) > > is more idiomatic. Thanks - I was sure that my lack of elisp foo was showing (even though I was quite proud that I was able to get it to work at all). I'll submit an updated patch for the 0.4 merge window. /D -- Dirk Hohndel Intel Open Source Technology Center