Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id EB2FF6DE13AC for ; Tue, 21 Apr 2015 18:35:35 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 0.343 X-Spam-Level: X-Spam-Status: No, score=0.343 tagged_above=-999 required=5 tests=[AWL=0.343] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Dnu-Z4EAID6O for ; Tue, 21 Apr 2015 18:35:33 -0700 (PDT) Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net [87.98.215.224]) by arlo.cworth.org (Postfix) with ESMTPS id 641886DE0AC2 for ; Tue, 21 Apr 2015 18:35:33 -0700 (PDT) Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim 4.80) (envelope-from ) id 1YkjXg-0007oj-Fk; Wed, 22 Apr 2015 01:33:32 +0000 Received: (nullmailer pid 14846 invoked by uid 1000); Wed, 22 Apr 2015 01:33:09 -0000 From: David Bremner To: Austin Clements , Ronny Chevalier Subject: Re: notmuch_thread_get_authors In-Reply-To: <87lhhlhryd.fsf@csail.mit.edu> References: <87618qfk5l.fsf@maritornes.cs.unb.ca> <87lhhlhryd.fsf@csail.mit.edu> User-Agent: Notmuch/0.19+96~g703c8f9 (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Wed, 22 Apr 2015 10:33:09 +0900 Message-ID: <874mo9ne0a.fsf@maritornes.cs.unb.ca> MIME-Version: 1.0 Content-Type: text/plain Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Apr 2015 01:35:36 -0000 Austin Clements writes: > You're completely right that there's no way to reliably parse the > authors list returned by notmuch_thread_get_authors. So don't do > that. Just use notmuch_thread_get_messages, walk the messages list, and > build your own authors list. There's no need to introduce additional > complexity and surface area into the library API for this specific use > case (IMO, even notmuch_thread_get_authors shouldn't exist, but it's > there for legacy reasons.) Ah, so when my DEPRECATED macros get merge, we should deprecate that function maybe. d