Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 678CC40DBE8 for ; Wed, 10 Nov 2010 16:26:06 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.89 X-Spam-Level: X-Spam-Status: No, score=-2.89 tagged_above=-999 required=5 tests=[ALL_TRUSTED=-1, BAYES_00=-1.9, T_MIME_NO_TEXT=0.01] autolearn=ham Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vKbYfjjmg4i7; Wed, 10 Nov 2010 16:25:56 -0800 (PST) Received: from yoom.home.cworth.org (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 1DCA640DBE3; Wed, 10 Nov 2010 16:25:56 -0800 (PST) Received: by yoom.home.cworth.org (Postfix, from userid 1000) id B84EB25412B; Wed, 10 Nov 2010 16:25:55 -0800 (PST) From: Carl Worth To: Michal Sojka , notmuch@notmuchmail.org Subject: Re: [PATCH] test: Better handling of stdout and stderr In-Reply-To: <87k4kkq3r2.fsf@yoom.home.cworth.org> References: <1289346035-24904-1-git-send-email-sojkam1@fel.cvut.cz> <87k4kkq3r2.fsf@yoom.home.cworth.org> User-Agent: Notmuch/0.4 (http://notmuchmail.org) Emacs/23.2.1 (i486-pc-linux-gnu) Date: Wed, 10 Nov 2010 16:25:49 -0800 Message-ID: <8739r8bt9u.fsf@yoom.home.cworth.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Nov 2010 00:26:06 -0000 --=-=-= Content-Transfer-Encoding: quoted-printable On Wed, 10 Nov 2010 13:15:45 -0800, Carl Worth wrote: > Meanwhile, I've just now pushed out my little test-lib.sh change, so you > can update the patch for that as well. Oh, and one other thing I forgot to mention about the patch. It currently talks about things along the lines of "git-style tests" and "cworth-style tests". You and I might understand perfectly well what that means now, but we need the test suite to be independently comprehensible. (I'd like to be able to understand it myself when I look at it again in the future, having forgotten the current history.) So if you could describe these instead as something like "tests using test_expect_success" vs. "tests using test_begin_subtest/test_expect_equal" or something like that, that would be great. Thanks again, =2DCarl =2D-=20 carl.d.worth@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iD8DBQFM2zgN6JDdNq8qSWgRAqboAKClMPpBilMUI8oZv3CrmDYzy+sZjQCfTx/u 6S4I6bqx2W+/kzN5zT8YlIo= =rnXq -----END PGP SIGNATURE----- --=-=-=--