Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 4EFE04196F2 for ; Sun, 4 Apr 2010 00:33:00 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.5 X-Spam-Level: X-Spam-Status: No, score=-0.5 tagged_above=-999 required=5 tests=[BAYES_05=-0.5] autolearn=unavailable Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id g93c0y9lQPF2 for ; Sun, 4 Apr 2010 00:32:58 -0700 (PDT) Received: from mail-ww0-f53.google.com (mail-ww0-f53.google.com [74.125.82.53]) by olra.theworths.org (Postfix) with ESMTP id 534254196F0 for ; Sun, 4 Apr 2010 00:32:58 -0700 (PDT) Received: by wwb22 with SMTP id 22so2024070wwb.26 for ; Sun, 04 Apr 2010 00:32:57 -0700 (PDT) Received: by 10.216.183.17 with SMTP id p17mr2555109wem.133.1270366377379; Sun, 04 Apr 2010 00:32:57 -0700 (PDT) Received: from ut.hh.sledj.net (host83-217-165-81.dsl.vispa.com [83.217.165.81]) by mx.google.com with ESMTPS id t12sm22950010gvd.21.2010.04.04.00.32.54 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 04 Apr 2010 00:32:55 -0700 (PDT) Received: by ut.hh.sledj.net (Postfix, from userid 1000) id 860505941EC; Sun, 4 Apr 2010 08:33:00 +0100 (BST) To: David Bremner , Carl Worth , notmuch In-Reply-To: <87pr2gs03u.fsf@rocinante.cs.unb.ca> References: <87oci344n4.fsf@ut.hh.sledj.net> <87bpe2j2vu.fsf@yoom.home.cworth.org> <87oci2xmkv.fsf@ut.hh.sledj.net> <87d3yhihzl.fsf@yoom.home.cworth.org> <87k4spxcz7.fsf@ut.hh.sledj.net> <87tyrsz5rp.fsf@yoom.home.cworth.org> <87pr2gs03u.fsf@rocinante.cs.unb.ca> From: David Edmondson Date: Sun, 04 Apr 2010 08:33:00 +0100 Message-ID: <87vdc7iser.fsf@ut.hh.sledj.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [notmuch] pull request [was Re: pull request] X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 04 Apr 2010 07:33:00 -0000 On Sat, 03 Apr 2010 18:21:57 -0300, David Bremner wrote: > The warnings about unknown functions can be eliminated by use the > declare-function macro; if you have emacs lisp reference manual (it > required the package emacs23-common-non-dfsg on Debian) then you can > run: > > ESC ESC : (info "(elisp)Declaring Functions") > > For variables, the obvious approach is to make a file 'notmuch-vars.el' > and put the variables we need in several files there. I'll declare common variables and 'exported' functions in 'notmuch-lib.el'. It may take a few days (I'm supposed to be on holiday). Carl: is a single changeset that creates notmuch-lib.el and moves the show implementation into notmuch-show.el okay? dme. -- David Edmondson, http://dme.org