Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 7B4314196F0 for ; Tue, 4 May 2010 21:46:52 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -1.5 X-Spam-Level: X-Spam-Status: No, score=-1.5 tagged_above=-999 required=5 tests=[BAYES_50=0.8, RCVD_IN_DNSWL_MED=-2.3] autolearn=ham Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eEPvTmGlqxS4 for ; Tue, 4 May 2010 21:46:51 -0700 (PDT) Received: from ipex1.johnshopkins.edu (ipex1.johnshopkins.edu [162.129.8.141]) by olra.theworths.org (Postfix) with ESMTP id 6F024431FC1 for ; Tue, 4 May 2010 21:46:51 -0700 (PDT) X-IronPort-AV: E=Sophos;i="4.52,331,1270440000"; d="scan'208";a="321179574" Received: from c-69-255-36-229.hsd1.md.comcast.net (HELO lucky) ([69.255.36.229]) by ipex1.johnshopkins.edu with ESMTP/TLS/AES256-SHA; 05 May 2010 00:46:50 -0400 Received: from jkr by lucky with local (Exim 4.71) (envelope-from ) id 1O9WVX-0003DI-Qs; Wed, 05 May 2010 00:46:51 -0400 From: Jesse Rosenthal To: Notmuch developer list Subject: Re: [PATCH 2/2] test: Have notmuch-test use the modular test collections In-Reply-To: <87fx2cdagi.fsf@jhu.edu> References: <87sk6cdbxz.fsf@jhu.edu> <87iq78daii.fsf@jhu.edu> <87fx2cdagi.fsf@jhu.edu> User-Agent: Notmuch/0.3.1-18-g688e1e7 (http://notmuchmail.org) Emacs/23.1.1 (i486-pc-linux-gnu) Date: Wed, 05 May 2010 00:46:51 -0400 Message-ID: <87k4rjgdl0.fsf@jhu.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 May 2010 04:46:52 -0000 These two patches, it turns out, do not quite go all the way -- they do not set up the environment to be exactly as it was in the full test suite. (I discovered this because my modular test suite did not fail on the recent xapian error -- failure being success in this case.) Further patches, which will be sent tomorrow, will take care of this in a very naive way: essentially repeating all the steps from the original suite up to each set of tests -- this means, of course, that the full test suite will take longer to run, since it will have to recreate the nm database for each collection. It's still quick enough though, and this can be improved if we change the expected results for each tests to conform to more uniquely tailored setups, instead of the leftovers from previous tests. Best, Jesse