Date: Mon, 22 Oct 2012 04:28:17 -0400
From: Austin Clements <amdragon@MIT.EDU>
To: Ethan Glasser-Camp <ethan.glasser.camp@gmail.com>
Subject: Re: [PATCH] test: new: Fix intermittent test failures with --debug
Message-ID: <20121022082817.GN14861@mit.edu>
References: <1350825298-8261-1-git-send-email-ethan@betacantrips.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1350825298-8261-1-git-send-email-ethan@betacantrips.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: notmuch@notmuchmail.org, Ethan Glasser-Camp <ethan@betacantrips.com>
Precedence: list

LGTM.

This is closely related to another problem in the test suite that
causes frequent failures for me when I run on tmpfs: generate_message
creates messages with the same time stamp by default, which means that
the output of date-sorted notmuch search is technically
non-deterministic.  I suspect this doesn't cause problems most of the
time or for most people because messages get added in the order
they're read from the file system (of course, this isn't guaranteed in
general and doesn't hold on tmpfs), which assigns them monotonically
increasing docids, which stabilizes the search results (though I don't
think this is guaranteed either).

Quoth Ethan Glasser-Camp on Oct 21 at  9:14 am:
> Although messages are created in a particular order, it seems that
> when they are created on a tmpfs, they do not always come back in the
> same order, leading to the same files being ignored but being output
> in a different order. This causes the test to fail because the outputs
> being compared are the same.
> 
> Fix the failures by sorting the output of notmuch --debug and
> comparing this to a hand-sorted version of its output.
> 
> Signed-off-by: Ethan Glasser-Camp <ethan@betacantrips.com>
> ---
>  test/new |   10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/test/new b/test/new
> index cc2af72..587aa11 100755
> --- a/test/new
> +++ b/test/new
> @@ -189,17 +189,17 @@ touch "${MAIL_DIR}"/.git # change .git's mtime for notmuch new to rescan.
>  mkdir -p "${MAIL_DIR}"/one/two/three/.git
>  notmuch new > /dev/null # ensure that files/folders will be printed in ASCII order.
>  touch "${MAIL_DIR}"/{one,one/two,one/two/three}/ignored_file
> -output=$(NOTMUCH_NEW --debug 2>&1)
> +output=$(NOTMUCH_NEW --debug 2>&1 | sort)
>  test_expect_equal "$output" \
>  "(D) add_files_recursive, pass 1: explicitly ignoring ${MAIL_DIR}/.git
>  (D) add_files_recursive, pass 1: explicitly ignoring ${MAIL_DIR}/one/two/three/.git
> -(D) add_files_recursive, pass 2: explicitly ignoring ${MAIL_DIR}/one/two/three/.git
> -(D) add_files_recursive, pass 2: explicitly ignoring ${MAIL_DIR}/one/two/three/ignored_file
> -(D) add_files_recursive, pass 2: explicitly ignoring ${MAIL_DIR}/one/two/ignored_file
> -(D) add_files_recursive, pass 2: explicitly ignoring ${MAIL_DIR}/one/ignored_file
>  (D) add_files_recursive, pass 2: explicitly ignoring ${MAIL_DIR}/.git
>  (D) add_files_recursive, pass 2: explicitly ignoring ${MAIL_DIR}/.ignored_hidden_file
>  (D) add_files_recursive, pass 2: explicitly ignoring ${MAIL_DIR}/ignored_file
> +(D) add_files_recursive, pass 2: explicitly ignoring ${MAIL_DIR}/one/ignored_file
> +(D) add_files_recursive, pass 2: explicitly ignoring ${MAIL_DIR}/one/two/ignored_file
> +(D) add_files_recursive, pass 2: explicitly ignoring ${MAIL_DIR}/one/two/three/.git
> +(D) add_files_recursive, pass 2: explicitly ignoring ${MAIL_DIR}/one/two/three/ignored_file
>  No new mail."
>  
>