From: Jameson Graef Rollins <jrollins@finestructure.net>
To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
Subject: Re: [PATCH v4 0/8] emacs: JSON-based search cleanups
In-Reply-To: <1342892232-5659-1-git-send-email-amdragon@mit.edu>
References: <1341354059-29396-1-git-send-email-amdragon@mit.edu>
	<1342892232-5659-1-git-send-email-amdragon@mit.edu>
User-Agent: Notmuch/0.13.2+90~gb97ff6a (http://notmuchmail.org) Emacs/23.4.1
	(x86_64-pc-linux-gnu)
Date: Sun, 22 Jul 2012 11:45:48 -0700
Message-ID: <87fw8j8wir.fsf@servo.finestructure.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha256; protocol="application/pgp-signature"
Precedence: list

--=-=-=

On Sat, Jul 21 2012, Austin Clements <amdragon@MIT.EDU> wrote:
> This version fixes several bugs found in the previous version.  I
> replaced the insert-before-markers trick in
> notmuch-search-update-result with direct point manipulation.  This
> fixes the problem with authors getting unhidden when a result is
> updated with point after the authors on the line (since it no longer
> deletes the region with the invisibility overlay).  I also removed the
> scrolling hack (which was partially necessitated by
> insert-before-markers), so that archiving the last visible result will
> properly scroll the buffer instead of jumping point to the middle of
> the visible window.  As a result, the window may scroll when updating
> a multiline result, however, it will scroll to show the entire result
> (unlike an earlier version where it scrolled to cut off the result
> because of an interaction with insert-before-markers).  Finally, I
> fixed notmuch-search-last-thread so that it behaves like it did before
> when there are no results, rather than failing with an obscure error.
>
> I also updated the customize documentation and NEWS to indicate that
> multiline search results are considered experimental.

This seems to fix the minor issues with the previous series, and seems
to be behaving great.  The changes and the documentation fixes look good
to me.

jamie.

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIcBAEBCAAGBQJQDEpcAAoJEO00zqvie6q89fUP/07h8F2HGBJChU9AAkchzmmG
ciJPtBdohEKJImtrrk/mIQ4m4tUGSVvoODe/I3ITciGjBBTagxaItaSyuWq+x6f+
MiJjfK0Qjwru8YKybx6jeJgEoZv/NPYvd/3Gm7kTjZAa269tpW5PtXiIzyYVQMIH
7MbDerMAckW9ySxrvjamYr8D2GNX49vYJ0z/Wshjt0yHgb0+vSBjBHEMBF3Rasv/
MqXKptC5z5WFNMpz89syOQTqlEJKveEgRS3y4UxLiO3D0YVTf05gJ5TBc/lCGaOX
4ggxGm4VuqlI9HiYisRZDso/xmLc3ztwoM0JfrflSvwCyQq7/3Ql30G36d05UKKZ
jLBX8hVwl4xV+RTq3woWUaHMH33SYHWmDybdzI3vA1azXcuVi9a875llcO2YbLB0
IFw8q6WkX9KP/iAlxL7DCb3NPDpyA2ryYPZLQsNLNBU4/rphTVZGAzF4x9l/QUM/
U/celaS+ycQP7Eh9KvIK2UF1FPJpI+vjbJNtG1SodAzEvkMhXz2wK2iZM9jpnky7
2X38C0VcDAGiKEr9GQCCNalSMhFE9ZcLdIjKAovN8fgUhjsYfWj0Z9FIzsJ1PBmo
br+4J3WBaZ3JwCBxw6PP+rvIXoGWt/tsxV96TBOqjO8/wziJkUBV6cV/tQ0tCvy9
HS6Egvlsypbmwk/OScUG
=x9V7
-----END PGP SIGNATURE-----
--=-=-=--