To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH 2/2] emacs: Don't move to the next thread unless the
	cursor is at the end of the buffer.
In-Reply-To: <87bopknvct.fsf@gmail.com>
References: <1327996914-9644-1-git-send-email-dme@dme.org>
	<1327996914-9644-3-git-send-email-dme@dme.org>
	<87bopknvct.fsf@gmail.com>
User-Agent: Notmuch/0.11+137~g7cd907b (http://notmuchmail.org) Emacs/24.0.92.1
	(x86_64-pc-linux-gnu)
From: David Edmondson <dme@dme.org>
Date: Tue, 31 Jan 2012 08:22:20 +0000
Message-ID: <cunaa54b7sz.fsf@hotblack-desiato.hh.sledj.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Precedence: list

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Tue, 31 Jan 2012 12:12:50 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmai=
l.com> wrote:
> On Tue, 31 Jan 2012 08:01:54 +0000, David Edmondson <dme@dme.org> wrote:
> > When using the spacebar to scroll through a thread, hitting 'space'
> > when the bottom of the last message is visible should take the cursor
> > to the end of the buffer rather than immediately archiving the thread
> > and moving to the next thread.
> > ---
>=20
> I did not notice this change yet, so +0
>=20
> A style comment below.
>=20
> >  emacs/notmuch-show.el |    5 +++++
> >  1 files changed, 5 insertions(+), 0 deletions(-)
> >=20
> > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> > index ec72ff8..3f54de0 100644
> > --- a/emacs/notmuch-show.el
> > +++ b/emacs/notmuch-show.el
> > @@ -1319,6 +1319,11 @@ current window), advance to the next open messag=
e."
> >        ;; This is not the last message - move to the next visible one.
> >        (notmuch-show-next-open-message))
> >=20=20
> > +     ((not (=3D (point) (point-max)))
> > +      ;; This is the last message, but the cursor is not at the end of
> > +      ;; the buffer. Move it there.
> > +      (goto-char (point-max)))
>=20
> Perhaps `unless' would be better here?

It's the CONDITION clause of `cond', so that wouldn't be appropriate.

> Regards,
>   Dmitry
>=20
> > +
> >       (t
> >        ;; This is the last message - change the return value
> >        (setq ret t)))
> > --=20
> > 1.7.8.3
> >=20
> > _______________________________________________
> > notmuch mailing list
> > notmuch@notmuchmail.org
> > http://notmuchmail.org/mailman/listinfo/notmuch

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk8npLwACgkQaezQq/BJZRZg8ACcCokp2iqFplIKTC4LyQb6BhbG
p4IAn1oTs6S9Wksjpyf7nZfDftOJOQZt
=2moY
-----END PGP SIGNATURE-----
--=-=-=--