Date: Wed, 24 Sep 2014 14:28:39 -0700
From: "W. Trevor King" <wking@tremily.us>
To: Austin Clements <aclements@csail.mit.edu>
Subject: Re: [PATCH v2] lib: Simplify close and codify aborting atomic section
Message-ID: <20140924212839.GE20130@odin.tremily.us>
References: <1411400615-20934-1-git-send-email-amdragon@mit.edu>
	<1411593623-8234-1-git-send-email-aclements@csail.mit.edu>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="bi5JUZtvcfApsciF"
Content-Disposition: inline
In-Reply-To: <1411593623-8234-1-git-send-email-aclements@csail.mit.edu>
OpenPGP: id=39A2F3FA2AB17E5D8764F388FC29BDCDF15F5BE8;
	url=http://tremily.us/pubkey.txt
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: notmuch@notmuchmail.org
Precedence: list


--bi5JUZtvcfApsciF
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Sep 24, 2014 at 05:20:23PM -0400, Austin Clements wrote:
> diff --git a/lib/notmuch.h b/lib/notmuch.h
> index fe2340b..5c40c67 100644
> --- a/lib/notmuch.h
> +++ b/lib/notmuch.h
> @@ -292,6 +292,11 @@ notmuch_database_open (const char *path,
>   * notmuch_database_close can be called multiple times.  Later calls
>   * have no effect.
>   *
> + * If the caller is currently in an atomic section (there was a
> + * notmuch_database_begin_atomic without a matching
> + * notmuch_database_end_atomic), this will abort the atomic section,
> + * discarding any modifications made in the atomic section.
> + *
>   * Return value:
>   *
>   * NOTMUCH_STATUS_SUCCESS: Successfully closed the database.

Still no mention of =E2=80=9Ccommit=E2=80=9D or =E2=80=9Cif you're not in a=
n atomic section=E2=80=9D
;).

Cheers,
Trevor

--=20
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy

--bi5JUZtvcfApsciF
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBAgAGBQJUIzeFAAoJEG8/JgBt8ol8Tx0P/39hs7vds2rIYlcdwtD2CvAT
eRzfIN7zYAFqvRolWkil7hc96Ylod2LFDr9xQRmugCuThk17TDlQ/MB3a71+VvK9
UinuSgZy30zI1pJN/wSGERsBIKMmotW03nJKXFf8nRRsAD7yyycvRM0LLXgSbasu
Gba8YT9IxN5Ko6mK28ETGP0tboJflqz9NDK3MIyfY0xsXCeAkYTLEVhec5VlzbJM
JKlYZ5Hfm76GHuGOey8b404Ye6eQRI8ZbWld7IIBzCYAAnfV2KFrSH/Qa5VOWZ5b
d7mhdpX7Wmmxvfly2DK51ItOO/oz5E87ZoFcnWbK3ESuKpGCmYV/R1EdCBY2Pba2
2ORAIOw/QFxvPygIntuCsGt0T0WRJytcwcyN03Brr/aDZrWGcFuyZiW3n5j9yYEX
B36+GUMDSJn9nVcHL1rM6ucudlULo667T1wNTSGYUL5mhuUs8m9ihsan/pYrWpyV
syHVoeh/wjyoPLUj9WTcBUyf6VPAYZ0/MqzZB8NM83By+u9J9FY85Tztw62w6SvI
rsEl7BardxRfs3qQbAc8JUzXgtv7mJnaggr5W13mAhciBemMgDwoQwYGORrhpAMm
ZRAu04aF5Zgee9vVGSxM2IZNTcIlaYkXAh6o7AzRdG+wLZXIhBE4ppyos9v3yH0o
7/y8isp/TIfvQWofZ9rp
=+UBI
-----END PGP SIGNATURE-----

--bi5JUZtvcfApsciF--