Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id A39C36DE1405 for ; Sat, 24 Oct 2015 03:35:53 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.046 X-Spam-Level: X-Spam-Status: No, score=-0.046 tagged_above=-999 required=5 tests=[AWL=0.524, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hrc-A1YKmwhh for ; Sat, 24 Oct 2015 03:35:52 -0700 (PDT) Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by arlo.cworth.org (Postfix) with ESMTPS id 94EBF6DE0B7C for ; Sat, 24 Oct 2015 03:35:51 -0700 (PDT) Received: by wicll6 with SMTP id ll6so59532682wic.1 for ; Sat, 24 Oct 2015 03:35:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:in-reply-to:references:user-agent:date:message-id :mime-version:content-type; bh=TYuWtvOgQq5kRo89ZUMzyc5nxZEKqcEGY46Nx7Unrq8=; b=rVAHKznnD1F+aoQUscAhs3W2K/iVxFXZXukhFkt+E4jpANgIAaFzyNtO9wsTP30qGV +1NFYcMgdBdgIfWxkR7IAmaO33Ab6xa8qCMttBOlzJ9vb6oWgMrYgZxCzUBZpy8ipdco Rrp6NTmIjXPlM65QgIGuyH/NFr6/u9Z/IV+gSFQ+RxsEdGVfbBnil6BZYJNDFeOcbZIj jHsgjuns2+M7kSOMRo5/vBFU7IzqOzpNzi1N2nB1ciI39WBiv1+ZAK/SdJxV5HXHYn6x rWXtcE366Wq7STDv8ipJB2BhreScyLwsB0JWpeObi4QzSM/w0tu636ahYvCVrd5RtZFA 3nlw== X-Received: by 10.194.77.146 with SMTP id s18mr11499804wjw.122.1445682949597; Sat, 24 Oct 2015 03:35:49 -0700 (PDT) Received: from localhost (5751dfa2.skybroadband.com. [87.81.223.162]) by smtp.gmail.com with ESMTPSA id p4sm6122707wia.15.2015.10.24.03.35.48 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 24 Oct 2015 03:35:48 -0700 (PDT) From: Mark Walters To: David Bremner , notmuch@notmuchmail.org, Jani Nikula Subject: Re: [Patch v5 2/3] emacs: convert notmuch-address-harvester to use notmuch-address In-Reply-To: <1445646037-25994-3-git-send-email-david@tethera.net> References: <1445646037-25994-1-git-send-email-david@tethera.net> <1445646037-25994-3-git-send-email-david@tethera.net> User-Agent: Notmuch/0.18~rc0+5~g35a33ff (http://notmuchmail.org) Emacs/23.4.1 (x86_64-pc-linux-gnu) Date: Sat, 24 Oct 2015 11:35:47 +0100 Message-ID: <87pp041rlo.fsf@qmul.ac.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Oct 2015 10:35:53 -0000 Hi I have looked through and tried patches 1 and 2 and it looks OK to me. So at least a sort of +1 on them combined (I didn't really look at them separately as they seem to make more sense as 1 lump). I agree with Jani about both the date option, and deduplicate possibility, and we may also want to add an option to use --output=sender. However, I think anything like that could come as a later patch. For the moment the only thing I think we need to consider is the variable notmuch-address-command. Do we want to have something other than nil to mean use the elisp completion? In particular we could have something which can be extended to specify the options above. Additionally, aesthetically, I like the idea that setting this variable to nil disables address completion. Best wishes Mark