Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 1ED46431FAF for ; Sat, 2 Nov 2013 05:22:44 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.699 X-Spam-Level: X-Spam-Status: No, score=-0.699 tagged_above=-999 required=5 tests=[HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4YVqohe36h2X for ; Sat, 2 Nov 2013 05:22:38 -0700 (PDT) Received: from mail-vc0-f171.google.com (mail-vc0-f171.google.com [209.85.220.171]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 1BB97431FAE for ; Sat, 2 Nov 2013 05:22:38 -0700 (PDT) Received: by mail-vc0-f171.google.com with SMTP id ik5so3539212vcb.2 for ; Sat, 02 Nov 2013 05:22:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=3UBUPW6wljv4Bq7vO9nGqRLIC99DXjnPmK/yaXc9P0A=; b=SUlutS/lQeVA7cjG8Ox72g0FW2dCV7Dw0KaW1IDTPVgB81T8vhv5Y+H2iqx8mutVN9 douHfzqr/VUvy/eqRRRuACdoeX3pHiPJJ+IXZ497ZNOXbuquYY3PY+C/cCrN4F+FI6Dq ZgUICp3BwJNVqlEe8Qe2iTzNExkZes93y9mQYVur5x4LxBk0XYvD3wnlM8mV5v/jrmtI YM1vkG9FNtdEdfY2dkO+R8tWooIqgKxLmn6R/XTkZ6pSJoi73I27P/YwmGXnRbXbC2Zy 4Xs+3hvfDw4rvO5pmdZtru3ISmdWX6+TwGlGq9slQax1fpIQlKOP+OJPBPf8g+T3Nnij GhaQ== X-Gm-Message-State: ALoCoQlkidzT3HgKZzHDFKK7P1Cj6PId6NWz7JanUwfi0Tgw+7j76pmuMuHaD0xd89HhbOMdsu2D MIME-Version: 1.0 X-Received: by 10.220.182.69 with SMTP id cb5mr283487vcb.41.1383394957503; Sat, 02 Nov 2013 05:22:37 -0700 (PDT) Received: by 10.58.96.20 with HTTP; Sat, 2 Nov 2013 05:22:37 -0700 (PDT) Received: by 10.58.96.20 with HTTP; Sat, 2 Nov 2013 05:22:37 -0700 (PDT) In-Reply-To: <87li17rof6.fsf@zancas.localnet> References: <9ee3f2334a117b0a1b88650f44432423cbe95fd7.1383315568.git.jani@nikula.org> <87li17rof6.fsf@zancas.localnet> Date: Sat, 2 Nov 2013 14:22:37 +0200 Message-ID: Subject: Re: [PATCH 3/6] lib: use the backup path provided by the user, don't add anything to it From: Jani Nikula To: David Bremner Content-Type: multipart/alternative; boundary=001a1132e2c2071dbb04ea30bd30 Cc: Notmuch Mail X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Nov 2013 12:22:44 -0000 --001a1132e2c2071dbb04ea30bd30 Content-Type: text/plain; charset=UTF-8 On Nov 2, 2013 2:14 PM, "David Bremner" wrote: > > Jani Nikula writes: > > > Adding another level is just useless cruft. > > --- > > lib/database.cc | 14 ++++---------- > > notmuch-compact.c | 4 ++-- > > 2 files changed, 6 insertions(+), 12 deletions(-) > > The first two patches are fine, modulo my comments about documentation. > I think the backup path needs to be updated in notmuch-compact.c, and > possible the test updated (after applying > id:1383350515-24320-1-git-send-email-david@tethera.net) > > d Ah, right, I was juggling the patch order back and forth a bit, and I missed this (as I drop the path completely in a later patch). Jani. --001a1132e2c2071dbb04ea30bd30 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On Nov 2, 2013 2:14 PM, "David Bremner" <david@tethera.net> wrote:
>
> Jani Nikula <jani@nikula.org= > writes:
>
> > Adding another level is just useless cruft.
> > ---
> > =C2=A0lib/database.cc =C2=A0 | =C2=A0 14 ++++----------
> > =C2=A0notmuch-compact.c | =C2=A0 =C2=A04 ++--
> > =C2=A02 files changed, 6 insertions(+), 12 deletions(-)
>
> The first two patches are fine, modulo my comments about documentation= .
> I think the backup path needs to be updated in notmuch-compact.c, and<= br> > possible the test updated (after applying
> id:1383350515-24320-1-git-send-email-david@tethera.net)
>
> d

Ah, right, I was juggling the patch order back and forth a b= it, and I missed this (as I drop the path completely in a later patch).

Jani.

--001a1132e2c2071dbb04ea30bd30--