Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 4A624429E26 for ; Thu, 12 Jan 2012 09:28:15 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id b3wGemkfGXEm for ; Thu, 12 Jan 2012 09:28:14 -0800 (PST) Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com [209.85.212.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 75675431FB6 for ; Thu, 12 Jan 2012 09:28:14 -0800 (PST) Received: by wibhr12 with SMTP id hr12so1517744wib.26 for ; Thu, 12 Jan 2012 09:28:13 -0800 (PST) Received: by 10.180.83.72 with SMTP id o8mr1939568wiy.22.1326389293356; Thu, 12 Jan 2012 09:28:13 -0800 (PST) Received: from localhost ([109.131.126.209]) by mx.google.com with ESMTPS id fo18sm6510828wbb.12.2012.01.12.09.28.12 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 12 Jan 2012 09:28:12 -0800 (PST) From: Pieter Praet To: David Bremner , Dmitry Kurochkin , notmuch@notmuchmail.org Subject: Re: [PATCH] cli: factor out config handling code to get/set lists. In-Reply-To: <87pqft8x4i.fsf@convex-new.cs.unb.ca> References: <87sjkstbiu.fsf@zancas.localnet> <1323619671-14111-1-git-send-email-david@tethera.net> <874nx76oxa.fsf@gmail.com> <87pqft8x4i.fsf@convex-new.cs.unb.ca> User-Agent: Notmuch/0.10.2+115~gadd29f6 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-unknown-linux-gnu) Date: Thu, 12 Jan 2012 18:26:33 +0100 Message-ID: <87y5tckf1y.fsf@praet.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jan 2012 17:28:15 -0000 On Mon, 12 Dec 2011 14:26:21 -0400, David Bremner wrote: > On Sun, 11 Dec 2011 20:41:53 +0400, Dmitry Kurochkin wrote: > > Hi David. > > > > On Sun, 11 Dec 2011 12:07:51 -0400, David Bremner wrote: > > > From: David Bremner > > > > > > Two new internal routines are created _config_get_list and > > > _config_set_list; the notmuch_config_get_* functions that deal with > > > lists are simply wrappers for these functions. > > Updated version pushed. I'm not completely happy with _config_get_list's > weird API, but I don't have a better idea now. > > d > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch Much cleaner! However... this would preferrably have been preceded by tests. Patch follows. Peace -- Pieter