Sender: Louis Rilling <lrilling@gmail.com>
Date: Tue, 12 Jul 2011 15:47:56 +0200
From: Louis Rilling <l.rilling@av7.net>
To: Austin Clements <amdragon@MIT.EDU>
Subject: Re: [PATCH 2/2] tags_to_maildir_flags: Don't rename if no flags
 change
Message-ID: <20110712134755.GA3279@localdomain>
References: <87d3hzgemi.fsf@yoom.home.cworth.org>
	<1310394978-11883-3-git-send-email-l.rilling@av7.net>
	<20110711200712.GB25558@mit.edu>
	<20110711223805.GC3583@localdomain>
	<20110712000344.GD25558@mit.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20110712000344.GD25558@mit.edu>
User-Agent: Mutt/1.5.20 (2009-06-14)
Cc: notmuch@notmuchmail.org
Precedence: list

On 11/07/11 20:03 -0400, Austin Clements wrote:
> > > The convention in notmuch is to use notmuch_bool_t, TRUE, and FALSE
> > > (though, admittedly, I don't know why; avoiding C99-isms?)
> > 
> > And bool is already used at another place in message.cc:
> > 
> > 	struct maildir_flag_tag {
> > 	    char flag;
> > 	    const char *tag;
> > 	    bool inverse;
> > 	};
> > 
> > IIUC it should be changed to notmuch_bool_t too.
> 
> Yes, I suppose it should (something slipped by cworth's eagle-eyed
> reviews!).  Though that appears to be the sole use of bool in all of
> libnotmuch.

I wonder if this is due to incompatible definitions of type bool in C99 and
C++. In that case this is probably harmless since struct maildir_flag_tag is
only visible from message.cc. Anyway, I'm sending a conversion patch together
with the updated series to make it clearer for Carl.

Thanks,

Louis