From: Tomi Ollila <tomi.ollila@iki.fi>
To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>,
	Jameson Graef Rollins <jrollins@finestructure.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH] test: make test_expect_equal_file() arguments flexible
In-Reply-To: <87pqdync64.fsf@gmail.com>
References: <1328080794-24670-1-git-send-email-dmitry.kurochkin@gmail.com>
	<87r4yfszx9.fsf@servo.finestructure.net> <87pqdync64.fsf@gmail.com>
User-Agent: Notmuch/0.11+146~geb6dc33 (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-unknown-linux-gnu)
Date: Wed, 01 Feb 2012 12:18:08 +0200
Message-ID: <m262fqc0wv.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list


There are at least these options here

1) go through all ~100 places where test_expect_equal_file is used
   and fix the call order: quick look tells that the offending uses
   are in dump-restore, hooks, search-limiting and symbol-hiding.

2) enforce "expected" filename has some format *and* fix all current
   uses of it. Add testbed_error () function which yells loudly ane exits...

3) guess which is output and which is expected from args so that 
   machine helps tester here (for both diff output & copied files)a

4) just copy compared files to some directory, those are named as
   basename of the original -- diff order still inconsistent.


I'd just go with option 1 and fix new *violations* when stumble upon one.

Tomi