From: David Bremner <david@tethera.net>
To: "W. Trevor King" <wking@tremily.us>
Subject: Re: [PATCH] lib: Simplify close and codify aborting atomic section
In-Reply-To: <20140924181844.GB20130@odin.tremily.us>
References: <1411400615-20934-1-git-send-email-amdragon@mit.edu>
	<20140922165954.GI20827@odin.tremily.us>
	<20140922185050.GB7970@csail.mit.edu>
	<20140922190022.GO20827@odin.tremily.us>
	<87iokc28mg.fsf@maritornes.cs.unb.ca>
	<20140924181844.GB20130@odin.tremily.us>
User-Agent: Notmuch/0.18.1+98~gae27403 (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-pc-linux-gnu)
Date: Wed, 24 Sep 2014 21:25:20 +0200
Message-ID: <87d2ak253z.fsf@maritornes.cs.unb.ca>
MIME-Version: 1.0
Content-Type: text/plain
Cc: notmuch@notmuchmail.org
Precedence: list

"W. Trevor King" <wking@tremily.us> writes:

>
> Sorry, I didn't phrase that very well.  The notmuch docs (as of this
> patch) explain that we don't commit if we're in an atomic block.  The
> Xapian docs also say that, *and* they say that if we're not in atomic
> block the close *does* try to commit.  I think that's worth mentioning
> in our close docs.

OK, I see what you mean. I think the fact that you have to close the
notmuch database (when not using begin/end atomic) to get a commit is
surprising for many people, so it would be nice to make that clearer
somehow.

d